(beam) branch master updated: Fix PostCommit Java DataflowV2 (#34209)

[yhu]

This is an automated email from the ASF dual-hosted git repository.

yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new dfc45f0d1fd Fix PostCommit Java DataflowV2 (#34209)
dfc45f0d1fd is described below

commit dfc45f0d1fd16c00141ab83abd42a78e9bd35ff6
Author: akashorabek <70029317+akashora...@users.noreply.github.com>
AuthorDate: Sat Mar 8 21:54:35 2025 +0500

    Fix PostCommit Java DataflowV2 (#34209)
    
    * Skip some tests on Dataflow runners
    
    * run spotless
    
    * changed to assumeFalse
    
    * format comments
    
    * add message to assumeFalse
---
 .../sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java | 15 ++++++++-------
 1 file changed, 8 insertions(+), 7 deletions(-)

diff --git 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
index 434e8bf3f4b..3cb9897ada5 100644
--- 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
+++ 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/bigquery/StorageApiSinkSchemaUpdateIT.java
@@ -22,6 +22,7 @@ import static org.junit.Assert.assertEquals;
 import static org.junit.Assert.assertNotNull;
 import static org.junit.Assert.assertNull;
 import static org.junit.Assert.assertTrue;
+import static org.junit.Assume.assumeFalse;
 import static org.junit.Assume.assumeTrue;
 
 import com.google.api.services.bigquery.model.Table;
@@ -372,8 +373,8 @@ public class StorageApiSinkSchemaUpdateIT {
     // Only run the most relevant test case on Dataflow
     if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
       assumeTrue(
-          "Skipping in favor of more relevant test case",
-          changeTableSchema && useInputSchema && useAutoSchemaUpdate);
+          "Skipping in favor of more relevant test case and to avoid timing 
issues",
+          !changeTableSchema && useInputSchema && useAutoSchemaUpdate);
     }
 
     List<String> fieldNamesOrigin = new 
ArrayList<String>(Arrays.asList(FIELDS));
@@ -618,11 +619,11 @@ public class StorageApiSinkSchemaUpdateIT {
     // Need to manually enable streaming engine for legacy dataflow runner
     ExperimentalOptions.addExperiment(
         p.getOptions().as(ExperimentalOptions.class), 
GcpOptions.STREAMING_ENGINE_EXPERIMENT);
-    // Only run the most relevant test case on Dataflow
-    if (p.getOptions().getRunner().getName().contains("DataflowRunner")) {
-      assumeTrue(
-          "Skipping in favor of more relevant test case", changeTableSchema && 
useInputSchema);
-    }
+    // Skipping dynamic destinations tests on Dataflow because of timing issues
+    // These tests are more stable on the DirectRunner, where timing is less 
variable
+    assumeFalse(
+        "Skipping dynamic destinations tests on Dataflow because of timing 
issues",
+        p.getOptions().getRunner().getName().contains("DataflowRunner"));
 
     List<String> fieldNamesOrigin = new 
ArrayList<String>(Arrays.asList(FIELDS));