This is an automated email from the ASF dual-hosted git repository.
xqhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new aa422055190 Log an error if parsing a meta option file fails. (#36060)
aa422055190 is described below
commit aa42205519001435ecf5d98179642d66027ff021
Author: Minbo Bae <[email protected]>
AuthorDate: Sat Sep 13 05:48:28 2025 -0700
Log an error if parsing a meta option file fails. (#36060)
---
sdks/java/container/boot.go | 13 +++++++------
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/sdks/java/container/boot.go b/sdks/java/container/boot.go
index 1f574d251cb..20283740ca0 100644
--- a/sdks/java/container/boot.go
+++ b/sdks/java/container/boot.go
@@ -227,9 +227,9 @@ func main() {
if pipelineOptions, ok :=
info.GetPipelineOptions().GetFields()["options"]; ok {
if heapDumpOption, ok :=
pipelineOptions.GetStructValue().GetFields()["enableHeapDumps"]; ok {
if heapDumpOption.GetBoolValue() {
- args = append(args, "-XX:+HeapDumpOnOutOfMemoryError",
-
"-Dbeam.fn.heap_dump_dir="+filepath.Join(dir, "heapdumps"),
- "-XX:HeapDumpPath="+filepath.Join(dir,
"heapdumps", "heap_dump.hprof"))
+ args = append(args,
"-XX:+HeapDumpOnOutOfMemoryError",
+
"-Dbeam.fn.heap_dump_dir="+filepath.Join(dir, "heapdumps"),
+ "-XX:HeapDumpPath="+filepath.Join(dir,
"heapdumps", "heap_dump.hprof"))
}
}
}
@@ -237,9 +237,10 @@ func main() {
// Apply meta options
const metaDir = "/opt/apache/beam/options"
- // Note: Error is unchecked, so parsing errors won't abort container.
- // TODO: verify if it's intentional or not.
- metaOptions, _ := LoadMetaOptions(ctx, logger, metaDir)
+ metaOptions, err := LoadMetaOptions(ctx, logger, metaDir)
+ if err != nil {
+ logger.Errorf(ctx, "LoadMetaOptions failed: %v", err)
+ }
javaOptions := BuildOptions(ctx, logger, metaOptions)
// (1) Add custom jvm arguments: "-server -Xmx1324 -XXfoo .."
