This is an automated email from the ASF dual-hosted git repository.
yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new bdf1be3e1f0 Changes multimap state key() tests to not care about
order. There is no guarantee on the order keys are returned. Also fixes a
couple warnings from other FnApi tests. (#36178)
bdf1be3e1f0 is described below
commit bdf1be3e1f062a4b157adb53abc4045f4a208af9
Author: Andrew Crites <[email protected]>
AuthorDate: Tue Sep 16 17:28:35 2025 -0700
Changes multimap state key() tests to not care about order. There is no
guarantee on the order keys are returned. Also fixes a couple warnings from
other FnApi tests. (#36178)
---
.../HarnessMonitoringInfosInstructionHandlerTest.java | 3 +++
.../beam/fn/harness/control/ProcessBundleHandlerTest.java | 1 +
.../beam/fn/harness/state/MultimapUserStateTest.java | 15 ++++++++++-----
3 files changed, 14 insertions(+), 5 deletions(-)
diff --git
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/HarnessMonitoringInfosInstructionHandlerTest.java
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/HarnessMonitoringInfosInstructionHandlerTest.java
index ac69ed29a56..9e69cb2ec70 100644
---
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/HarnessMonitoringInfosInstructionHandlerTest.java
+++
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/HarnessMonitoringInfosInstructionHandlerTest.java
@@ -30,7 +30,10 @@ import org.apache.beam.runners.core.metrics.ShortIdMap;
import org.apache.beam.sdk.metrics.Counter;
import org.apache.beam.sdk.metrics.MetricsEnvironment;
import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+@RunWith(JUnit4.class)
public class HarnessMonitoringInfosInstructionHandlerTest {
@Test
diff --git
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
index 8a35351fdb2..a7a62571e38 100644
---
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
+++
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/control/ProcessBundleHandlerTest.java
@@ -236,6 +236,7 @@ public class ProcessBundleHandlerTest {
}
}
+ @SuppressWarnings("ExtendsAutoValue")
private static class TestBundleProcessor extends BundleProcessor {
static int resetCnt = 0;
diff --git
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/MultimapUserStateTest.java
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/MultimapUserStateTest.java
index 17550793a8b..48c9ce43bdf 100644
---
a/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/MultimapUserStateTest.java
+++
b/sdks/java/harness/src/test/java/org/apache/beam/fn/harness/state/MultimapUserStateTest.java
@@ -21,6 +21,7 @@ import static java.util.Arrays.asList;
import static java.util.Collections.singletonList;
import static org.hamcrest.MatcherAssert.assertThat;
import static org.hamcrest.Matchers.emptyIterable;
+import static org.hamcrest.collection.ArrayMatching.arrayContainingInAnyOrder;
import static org.hamcrest.core.Is.is;
import static org.junit.Assert.assertArrayEquals;
import static org.junit.Assert.assertEquals;
@@ -167,7 +168,9 @@ public class MultimapUserStateTest {
userState.put(A3, "V1");
userState.put(A1, "V3");
assertArrayEquals(new byte[][] {A1, A2}, Iterables.toArray(initKeys,
byte[].class));
- assertArrayEquals(new byte[][] {A1, A2, A3},
Iterables.toArray(userState.keys(), byte[].class));
+ assertThat(
+ Iterables.toArray(userState.keys(), byte[].class),
+ is(arrayContainingInAnyOrder(A1, A2, A3)));
userState.clear();
assertArrayEquals(new byte[][] {A1, A2}, Iterables.toArray(initKeys,
byte[].class));
@@ -822,8 +825,9 @@ public class MultimapUserStateTest {
userState.put(A2, "V1");
userState.put(A3, "V1");
- assertArrayEquals(
- new byte[][] {A1, A2, A3}, Iterables.toArray(userState.keys(),
byte[].class));
+ assertThat(
+ Iterables.toArray(userState.keys(), byte[].class),
+ is(arrayContainingInAnyOrder(A1, A2, A3)));
userState.asyncClose();
}
@@ -841,8 +845,9 @@ public class MultimapUserStateTest {
ByteArrayCoder.of(),
StringUtf8Coder.of());
- assertArrayEquals(
- new byte[][] {A1, A2, A3}, Iterables.toArray(userState.keys(),
byte[].class));
+ assertThat(
+ Iterables.toArray(userState.keys(), byte[].class),
+ is(arrayContainingInAnyOrder(A1, A2, A3)));
userState.asyncClose();
}
}