[
https://issues.apache.org/jira/browse/BEAM-2166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999092#comment-15999092
]
ASF GitHub Bot commented on BEAM-2166:
--------------------------------------
GitHub user robertwb opened a pull request:
https://github.com/apache/beam/pull/2930
[BEAM-2166] Remove context from size estimating operations.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/robertwb/incubator-beam coders-context-sizes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2930.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2930
----
commit 1e36619bba7eb3e16078fb484961ebabc7331876
Author: Robert Bradshaw <[email protected]>
Date: 2017-05-05T22:18:52Z
Remove context from size estimate operations.
commit 7453171e4acb7e22505d172fcd790db599b33e54
Author: Robert Bradshaw <[email protected]>
Date: 2017-05-05T22:23:03Z
Remove uses of context in coder size estimation calls.
find . -type f -name '*.java' | xargs sed -i ''
's/\([a-zA-Z]*[bB]yteSize[a-zA-Z]*[(].*\),
[^,]*[Cc]ontext[^,()]*\([(][)]\)*[)]/\1)/'
plus a one-off Python script and some manual fixups.
----
> Remove Coder.Context from the public API
> ----------------------------------------
>
> Key: BEAM-2166
> URL: https://issues.apache.org/jira/browse/BEAM-2166
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core, sdk-py
> Affects Versions: First stable release
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Fix For: First stable release
>
>
> Justification:
> * Contexts add confusion and complexity to the public API (e.g.
> https://issues.apache.org/jira/browse/BEAM-1448)
> * Leaf (user-written) coders are nearly always nested.
> * Coders are being removed from sources, which was the initial need for
> context.
> * It is unclear how much value, if any, this provides for internal
> performance.
> * There may be performance (as well as simplification) gains in removing this
> for the Fn API.
> Fully removing this distinction from the internals can be defered until the
> last bullet points are more completely investigated.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
