[
https://issues.apache.org/jira/browse/BEAM-2151?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15999668#comment-15999668
]
ASF GitHub Bot commented on BEAM-2151:
--------------------------------------
Github user xumingming closed the pull request at:
https://github.com/apache/beam/pull/2886
> Type mapping inconsistent in BeamSqlRow & BeamSqlRowCoder
> ---------------------------------------------------------
>
> Key: BEAM-2151
> URL: https://issues.apache.org/jira/browse/BEAM-2151
> Project: Beam
> Issue Type: Bug
> Components: dsl-sql
> Reporter: James Xu
> Assignee: James Xu
> Priority: Blocker
>
> In BeamSqlRow, sql FLOAT is mapping to java Float:
> {code:java}
> case FLOAT:
> if (!(fieldValue instanceof Float)) {
> throw new InvalidFieldException(
> String.format("[%s] doesn't match type [%s]", fieldValue,
> fieldType));
> }
> break;
> {code}
> but in BeamSqlRowCoder, sql FLOAT is treated as java Double:
> {code:java}
> case DOUBLE:
> case FLOAT:
> doubleCoder.encode(value.getDouble(idx), outStream, nested);
> break;
> {code}
> Let's mapping sql FLOAT consistently to java Float?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
