This is an automated email from the ASF dual-hosted git repository.

shunping pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 0f6b605f9e5 Fix a bug in streaming OrderedWindowElements. (#36642)
0f6b605f9e5 is described below

commit 0f6b605f9e5fea5a384029deca6bfa9bba85218d
Author: Shunping Huang <[email protected]>
AuthorDate: Mon Oct 27 22:18:35 2025 -0400

    Fix a bug in streaming OrderedWindowElements. (#36642)
---
 .../examples/cookbook/ordered_window_elements/streaming.py            | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git 
a/sdks/python/apache_beam/examples/cookbook/ordered_window_elements/streaming.py
 
b/sdks/python/apache_beam/examples/cookbook/ordered_window_elements/streaming.py
index 724fc4df551..450c90685ac 100644
--- 
a/sdks/python/apache_beam/examples/cookbook/ordered_window_elements/streaming.py
+++ 
b/sdks/python/apache_beam/examples/cookbook/ordered_window_elements/streaming.py
@@ -212,7 +212,7 @@ class OrderedWindowElementsDoFn(beam.DoFn):
       _LOGGER.info(
           "[process] setting initial timer to %s",
           first_window_end_ts + self.allowed_lateness)
-      if (self.stop_timestamp is not None and
+      if (self.stop_timestamp is None or
           first_window_end_ts + self.allowed_lateness < self.stop_timestamp):
         window_timer.set(first_window_end_ts + self.allowed_lateness)
 
@@ -368,7 +368,7 @@ class OrderedWindowElementsDoFn(beam.DoFn):
     _LOGGER.info(
         "[on_timer] setting follow-up timer to %s",
         next_window_end_ts + self.allowed_lateness)
-    if (self.stop_timestamp is not None and
+    if (self.stop_timestamp is None or
         next_window_end_ts + self.allowed_lateness < self.stop_timestamp):
       window_timer.set(next_window_end_ts + self.allowed_lateness)
 

Reply via email to