[
https://issues.apache.org/jira/browse/BEAM-1982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16000702#comment-16000702
]
ASF GitHub Bot commented on BEAM-1982:
--------------------------------------
GitHub user hepeknet opened a pull request:
https://github.com/apache/beam/pull/2949
BEAM-1982 - adding common method to extract singleton main input
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-1982>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
@tgroh is this good enough or should I expand on this as described in my
JIRA comment?
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hepeknet/beam BEAM-1982
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2949.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2949
----
commit 09acf872fba9f3a77ad57c35545b410aeee9477f
Author: Borisa Zivkovic <[email protected]>
Date: 2017-05-08T12:53:17Z
adding common method to extract singleton main input
----
> Refactor PTransformOverrideFactories to remove code duplication
> ---------------------------------------------------------------
>
> Key: BEAM-1982
> URL: https://issues.apache.org/jira/browse/BEAM-1982
> Project: Beam
> Issue Type: Bug
> Components: runner-core
> Reporter: Thomas Groh
> Priority: Minor
> Labels: newbie, starter
>
> The majority of the factories take in a single PCollection as input and
> produce a single PCollection as output; the code to extract the single input
> can be invisible as part of the class hierarchy, rather than explicitly
> called in every override.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
