[
https://issues.apache.org/jira/browse/BEAM-2212?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001329#comment-16001329
]
ASF GitHub Bot commented on BEAM-2212:
--------------------------------------
GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/2958
[BEAM-2212] Cherry-pick #2956 into release-2.0.0 branch
R: @davorbonaci
May not be worth CPing, it's just improving LOGs and error messages.
Thoughts?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam cp-2956
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2958.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2958
----
commit 32539c70e1661c62730939f158d14fcf543e2237
Author: Dan Halperin <[email protected]>
Date: 2017-05-06T02:06:03Z
[BEAM-2212] FileBasedSource: improve message when logging.
ValueProvider should not be printed, rather the string instead.
commit 1e2b6dbaacde05d4074172df0ed77a6ffbac83b6
Author: Dan Halperin <[email protected]>
Date: 2017-05-08T16:59:16Z
[BEAM-2212] FileBasedSource: refactor to remove uses of
fileOrPatternSpec.get()
Makes it less likely to have errors from printing ValueProviders instead of
runtime values
----
> ValueProvider-ification of core transforms makes logs and errors worse
> ----------------------------------------------------------------------
>
> Key: BEAM-2212
> URL: https://issues.apache.org/jira/browse/BEAM-2212
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Daniel Halperin
> Assignee: Daniel Halperin
>
> E.g., we routinely log things like "Reading from
> StandardValueProvider{somefile}" instead of "Reading from somefile".
> This should be audited and cleaned up.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
