[
https://issues.apache.org/jira/browse/BEAM-2213?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16001437#comment-16001437
]
ASF GitHub Bot commented on BEAM-2213:
--------------------------------------
GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/2961
[BEAM-2213] Convert Executor Services to use Daemon Threads
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This will cause the DirectRunner to automatically shut down when the
worker threads are shut down.
Merged to master in #2954
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam executor_daemons_rls
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/2961.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2961
----
commit b69a9b84e17463c0921d3edc38f47c1d26e81521
Author: Dan Halperin <[email protected]>
Date: 2017-05-06T02:49:29Z
Convert Executor Services to use Daemon Threads
This will cause the DirectRunner to automatically shut down when the
worker threads are shut down.
----
> Java DirectRunner takes 60s to shut down after wordcount runs
> -------------------------------------------------------------
>
> Key: BEAM-2213
> URL: https://issues.apache.org/jira/browse/BEAM-2213
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Daniel Halperin
> Assignee: Thomas Groh
> Fix For: 2.0.0
>
>
> After I run WordCount, it seems like the job is done (output files are
> created) yet the Java process seems to hang for nearly exactly 60s.
> We've seen issues like this in the past; working hypothesis is something
> wrong with the executors.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
