This is an automated email from the ASF dual-hosted git repository.
yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 4e76198555e fix spotless (#37508)
4e76198555e is described below
commit 4e76198555e76672c2be3439b9152d483351e7f5
Author: Tarun Annapareddy <[email protected]>
AuthorDate: Wed Feb 4 17:06:12 2026 -0800
fix spotless (#37508)
---
.../io/components/deadletterqueue/DLQRouter.java | 21 +++++++++------
.../deadletterqueue/sinks/ThrowingSink.java | 3 +--
.../components/throttling/ThrottlingSignaler.java | 11 ++++----
.../components/deadletterqueue/DLQRouterTest.java | 30 ++++++++++------------
4 files changed, 33 insertions(+), 32 deletions(-)
diff --git
a/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouter.java
b/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouter.java
index 6b4485db216..a6c99f807d0 100644
---
a/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouter.java
+++
b/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouter.java
@@ -17,7 +17,6 @@
*/
package org.apache.beam.sdk.io.components.deadletterqueue;
-
import java.util.HashMap;
import java.util.Map;
import org.apache.beam.sdk.transforms.PTransform;
@@ -26,27 +25,33 @@ import org.apache.beam.sdk.values.PCollectionTuple;
import org.apache.beam.sdk.values.TupleTag;
import org.checkerframework.checker.nullness.qual.NonNull;
-public class DLQRouter<T, K> extends PTransform<@NonNull PCollectionTuple,
@NonNull PCollection<T>> {
+public class DLQRouter<T, K>
+ extends PTransform<@NonNull PCollectionTuple, @NonNull PCollection<T>> {
private final TupleTag<T> goodMessages;
private final TupleTag<K> badMessages;
- private final PTransform<@NonNull PCollection<K>,?> errorSink;
+ private final PTransform<@NonNull PCollection<K>, ?> errorSink;
- public DLQRouter (TupleTag<T> goodMessages, TupleTag<K> badMessages,
PTransform<@NonNull PCollection<K>,?> errorSink){
+ public DLQRouter(
+ TupleTag<T> goodMessages,
+ TupleTag<K> badMessages,
+ PTransform<@NonNull PCollection<K>, ?> errorSink) {
this.goodMessages = goodMessages;
this.badMessages = badMessages;
this.errorSink = errorSink;
}
+
@Override
public PCollection<T> expand(@NonNull PCollectionTuple input) {
- //validate no extra messages are dropped
- Map<TupleTag<?>,PCollection<?>> pcollections = new
HashMap<>(input.getAll());
+ // validate no extra messages are dropped
+ Map<TupleTag<?>, PCollection<?>> pcollections = new
HashMap<>(input.getAll());
pcollections.remove(goodMessages);
pcollections.remove(badMessages);
- if (pcollections.size() != 0){
- throw new IllegalArgumentException("DLQ Router only supports
PCollectionTuples split between two message groupings");
+ if (pcollections.size() != 0) {
+ throw new IllegalArgumentException(
+ "DLQ Router only supports PCollectionTuples split between two
message groupings");
}
input.get(badMessages).apply(errorSink);
diff --git
a/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/sinks/ThrowingSink.java
b/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/sinks/ThrowingSink.java
index 9869cd09da3..73970d8a7c6 100644
---
a/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/sinks/ThrowingSink.java
+++
b/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/deadletterqueue/sinks/ThrowingSink.java
@@ -17,7 +17,6 @@
*/
package org.apache.beam.sdk.io.components.deadletterqueue.sinks;
-
import
org.apache.beam.repackaged.core.org.apache.commons.lang3.ObjectUtils.Null;
import org.apache.beam.sdk.transforms.DoFn;
import org.apache.beam.sdk.transforms.PTransform;
@@ -38,7 +37,7 @@ public class ThrowingSink<T> extends PTransform<@NonNull
PCollection<T>, @NonNul
public class ThrowingDoFn extends DoFn<T, Null> {
@ProcessElement
- public void processElement(@Element @NonNull T element){
+ public void processElement(@Element @NonNull T element) {
throw new RuntimeException(element.toString());
}
}
diff --git
a/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/throttling/ThrottlingSignaler.java
b/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/throttling/ThrottlingSignaler.java
index 894c9294bed..9bd4466997f 100644
---
a/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/throttling/ThrottlingSignaler.java
+++
b/sdks/java/io/components/src/main/java/org/apache/beam/sdk/io/components/throttling/ThrottlingSignaler.java
@@ -19,11 +19,11 @@ package org.apache.beam.sdk.io.components.throttling;
import org.apache.beam.sdk.metrics.Counter;
import org.apache.beam.sdk.metrics.Metrics;
+
/**
- * The ThrottlingSignaler is a utility class for IOs to signal to the runner
- * that a process is being throttled, preventing autoscaling. This is primarily
- * used when making calls to a remote service where quotas and rate limiting
- * are reasonable considerations.
+ * The ThrottlingSignaler is a utility class for IOs to signal to the runner
that a process is being
+ * throttled, preventing autoscaling. This is primarily used when making calls
to a remote service
+ * where quotas and rate limiting are reasonable considerations.
*/
public class ThrottlingSignaler {
private final Counter throttleCounter;
@@ -37,8 +37,7 @@ public class ThrottlingSignaler {
}
/**
- * Signal that a transform has been throttled for an amount of time
- * represented in milliseconds.
+ * Signal that a transform has been throttled for an amount of time
represented in milliseconds.
*/
public void signalThrottling(long milliseconds) {
throttleCounter.inc(milliseconds);
diff --git
a/sdks/java/io/components/src/test/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouterTest.java
b/sdks/java/io/components/src/test/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouterTest.java
index 8d2e5d296f4..09e886da97b 100644
---
a/sdks/java/io/components/src/test/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouterTest.java
+++
b/sdks/java/io/components/src/test/java/org/apache/beam/sdk/io/components/deadletterqueue/DLQRouterTest.java
@@ -17,7 +17,6 @@
*/
package org.apache.beam.sdk.io.components.deadletterqueue;
-
import org.apache.beam.sdk.io.components.deadletterqueue.sinks.ThrowingSink;
import org.apache.beam.sdk.testing.PAssert;
import org.apache.beam.sdk.testing.TestPipeline;
@@ -31,46 +30,45 @@ import org.junit.rules.ExpectedException;
public class DLQRouterTest {
- @Rule
- public final transient TestPipeline p = TestPipeline.create();
+ @Rule public final transient TestPipeline p = TestPipeline.create();
@Rule public ExpectedException thrown = ExpectedException.none();
-
@Test
- public void testExceptionWithInvalidConfiguration(){
+ public void testExceptionWithInvalidConfiguration() {
thrown.expect(IllegalArgumentException.class);
- thrown.expectMessage("DLQ Router only supports PCollectionTuples split
between two message groupings");
+ thrown.expectMessage(
+ "DLQ Router only supports PCollectionTuples split between two message
groupings");
TupleTag<String> tag1 = new TupleTag<>();
TupleTag<String> tag2 = new TupleTag<>();
TupleTag<String> tag3 = new TupleTag<>();
- PCollectionTuple tuple = PCollectionTuple.of(tag1,
p.apply(Create.<String>of("elem1")))
- .and(tag2, p.apply(Create.<String>of("elem2")))
- .and(tag3, p.apply(Create.<String>of("elem1")));
+ PCollectionTuple tuple =
+ PCollectionTuple.of(tag1, p.apply(Create.<String>of("elem1")))
+ .and(tag2, p.apply(Create.<String>of("elem2")))
+ .and(tag3, p.apply(Create.<String>of("elem1")));
tuple.apply(new DLQRouter<>(tag1, tag2, new ThrowingSink<>()));
p.run();
-
}
@Test
- public void testExpectCorrectRouting(){
+ public void testExpectCorrectRouting() {
thrown.expect(RuntimeException.class);
thrown.expectMessage("elem2");
TupleTag<String> tag1 = new TupleTag<>();
TupleTag<String> tag2 = new TupleTag<>();
- PCollectionTuple tuple = PCollectionTuple.of(tag1, p.apply("create elem1",
Create.<String>of("elem1")))
- .and(tag2, p.apply("create elem2", Create.<String>of("elem2")));
+ PCollectionTuple tuple =
+ PCollectionTuple.of(tag1, p.apply("create elem1",
Create.<String>of("elem1")))
+ .and(tag2, p.apply("create elem2", Create.<String>of("elem2")));
- PCollection<String> expectedElement = tuple.apply(new DLQRouter<>(tag1,
tag2, new ThrowingSink<>()));
+ PCollection<String> expectedElement =
+ tuple.apply(new DLQRouter<>(tag1, tag2, new ThrowingSink<>()));
PAssert.thatSingleton(expectedElement).isEqualTo("elem1");
p.run();
}
-
-
}
