This is an automated email from the ASF dual-hosted git repository.
yhu pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git
The following commit(s) were added to refs/heads/master by this push:
new 96306945ad6 refactor: Remove redundant protected access modifiers and
enable the `ProtectedMembersInFinalClass` ErrorProne check. (#37757)
96306945ad6 is described below
commit 96306945ad61d81696ae874abed48ec23a9c7f6b
Author: Radosław Stankiewicz <[email protected]>
AuthorDate: Thu Mar 5 01:20:42 2026 +0100
refactor: Remove redundant protected access modifiers and enable the
`ProtectedMembersInFinalClass` ErrorProne check. (#37757)
---
.../src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy | 1 -
.../dataflow/worker/util/common/worker/CachingShuffleBatchReader.java | 4 ++--
.../core/src/main/java/org/apache/beam/sdk/coders/DelegateCoder.java | 2 +-
.../src/main/java/org/apache/beam/sdk/coders/StringDelegateCoder.java | 2 +-
.../java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java | 3 +--
.../io/gcp/firestore/PartitionQueryResponseToRunQueryRequestTest.java | 2 +-
6 files changed, 6 insertions(+), 8 deletions(-)
diff --git
a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
index 134af9a8b4c..5b90afac1a3 100644
--- a/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
+++ b/buildSrc/src/main/groovy/org/apache/beam/gradle/BeamModulePlugin.groovy
@@ -1559,7 +1559,6 @@ class BeamModulePlugin implements Plugin<Project> {
"MixedMutabilityReturnType",
"PreferJavaTimeOverload",
"NonCanonicalType",
- "ProtectedMembersInFinalClass",
"Slf4jFormatShouldBeConst",
"Slf4jSignOnlyFormat",
"StaticAssignmentInConstructor",
diff --git
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/CachingShuffleBatchReader.java
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/CachingShuffleBatchReader.java
index 7dd637b093f..af37a881262 100644
---
a/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/CachingShuffleBatchReader.java
+++
b/runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/util/common/worker/CachingShuffleBatchReader.java
@@ -83,8 +83,8 @@ public class CachingShuffleBatchReader implements
ShuffleBatchReader {
/** The key for the entries stored in the batch cache. */
static final class BatchRange {
- protected final @Nullable ShufflePosition startPosition;
- protected final @Nullable ShufflePosition endPosition;
+ final @Nullable ShufflePosition startPosition;
+ final @Nullable ShufflePosition endPosition;
public BatchRange(
@Nullable ShufflePosition startPosition, @Nullable ShufflePosition
endPosition) {
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/DelegateCoder.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/DelegateCoder.java
index 03550cc4e06..a855934d014 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/DelegateCoder.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/DelegateCoder.java
@@ -176,7 +176,7 @@ public final class DelegateCoder<T, IntermediateT> extends
CustomCoder<T> {
// to try to deduce a good type descriptor.
private final @Nullable TypeDescriptor<T> typeDescriptor;
- protected DelegateCoder(
+ DelegateCoder(
Coder<IntermediateT> coder,
CodingFunction<T, IntermediateT> toFn,
CodingFunction<IntermediateT, T> fromFn,
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StringDelegateCoder.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StringDelegateCoder.java
index 431e348721e..cadbd9e65e1 100644
---
a/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StringDelegateCoder.java
+++
b/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/StringDelegateCoder.java
@@ -58,7 +58,7 @@ public final class StringDelegateCoder<T> extends
CustomCoder<T> {
private final DelegateCoder<T, String> delegateCoder;
private final Class<T> clazz;
- protected StringDelegateCoder(final Class<T> clazz, TypeDescriptor<T>
typeDescriptor) {
+ StringDelegateCoder(final Class<T> clazz, TypeDescriptor<T> typeDescriptor) {
delegateCoder =
DelegateCoder.of(
StringUtf8Coder.of(),
diff --git
a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
index 77973a0a3e4..bba9b1f82f5 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/FileBasedSink.java
@@ -1177,8 +1177,7 @@ public abstract class FileBasedSink<UserT, DestinationT,
OutputT>
private final Coder<BoundedWindow> windowCoder;
private final Coder<DestinationT> destinationCoder;
- protected FileResultCoder(
- Coder<BoundedWindow> windowCoder, Coder<DestinationT>
destinationCoder) {
+ FileResultCoder(Coder<BoundedWindow> windowCoder, Coder<DestinationT>
destinationCoder) {
this.windowCoder = NullableCoder.of(windowCoder);
this.destinationCoder = destinationCoder;
}
diff --git
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/PartitionQueryResponseToRunQueryRequestTest.java
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/PartitionQueryResponseToRunQueryRequestTest.java
index c6df81f20e7..6f0ad3a710d 100644
---
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/PartitionQueryResponseToRunQueryRequestTest.java
+++
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/firestore/PartitionQueryResponseToRunQueryRequestTest.java
@@ -50,7 +50,7 @@ import org.mockito.junit.MockitoJUnitRunner;
"initialization.fields.uninitialized") // mockito fields are initialized
via the Mockito Runner
public final class PartitionQueryResponseToRunQueryRequestTest {
- @Mock protected DoFn<PartitionQueryPair, RunQueryRequest>.ProcessContext
processContext;
+ @Mock DoFn<PartitionQueryPair, RunQueryRequest>.ProcessContext
processContext;
private final StructuredQuery query =
StructuredQuery.newBuilder()
