[ https://issues.apache.org/jira/browse/BEAM-2076?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16003561#comment-16003561 ]
ASF GitHub Bot commented on BEAM-2076: -------------------------------------- GitHub user tgroh opened a pull request: https://github.com/apache/beam/pull/3005 [BEAM-2076] Make PCollectionViewWindow package private Be sure to do all of the following to help us incorporate your contribution quickly and easily: - [ ] Make sure the PR title is formatted like: `[BEAM-<Jira issue #>] Description of pull request` - [ ] Make sure tests pass via `mvn clean verify`. - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue number, if there is one. - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- grep -lr "^public " runners/direct-java/src/main/java runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRegistrar.java runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectOptions.java runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java You can merge this pull request into a Git repository by running: $ git pull https://github.com/tgroh/beam package_private_view_window Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3005.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3005 ---- commit 07084adde3a399a9f8f4863329af2b987ce29a08 Author: Thomas Groh <tg...@google.com> Date: 2017-05-09T21:04:39Z Make PCollectionViewWindow package private grep -lr "^public " runners/direct-java/src/main/java runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRegistrar.java runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectOptions.java runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectRunner.java ---- > DirectRunner: minimal transitive API surface > -------------------------------------------- > > Key: BEAM-2076 > URL: https://issues.apache.org/jira/browse/BEAM-2076 > Project: Beam > Issue Type: Improvement > Components: runner-direct > Reporter: Daniel Halperin > Assignee: Thomas Groh > Fix For: 2.0.0 > > > The {{DirectRunner}} is likely to accidentally be on many users' classpath > when they are running on other runners. As such, it should have a minimal > transitive API surface, shading things it needs directly and need not expose. > My base assumption is that {{runners-core}} should be shaded. There may be > others tho -- this merits a bit of a look. -- This message was sent by Atlassian JIRA (v6.3.15#6346)