(beam) branch master updated: [Cloud Spanner Change Streams] Fix inverted evaluation of cancelQueryOnHeartbeat (#38695)

[scwhittle]

This is an automated email from the ASF dual-hosted git repository.

scwhittle pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/beam.git


The following commit(s) were added to refs/heads/master by this push:
     new 9583fe94755 [Cloud Spanner Change Streams] Fix inverted evaluation of 
cancelQueryOnHeartbeat (#38695)
9583fe94755 is described below

commit 9583fe947555dc56bb73cd2b1b02c772fa0f7ddc
Author: Sam Whittle <scwhit...@users.noreply.github.com>
AuthorDate: Wed May 27 13:50:33 2026 +0200

    [Cloud Spanner Change Streams] Fix inverted evaluation of 
cancelQueryOnHeartbeat (#38695)
    
    This meant that low latency mode for heartbeats was enabled by default and 
disabled in low latency mode instead of the desired opposite.
---
 .../io/gcp/spanner/changestreams/action/HeartbeatRecordAction.java    | 2 +-
 .../gcp/spanner/changestreams/action/HeartbeatRecordActionTest.java   | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordAction.java
 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordAction.java
index 1b66a548b3d..773f54a15d2 100644
--- 
a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordAction.java
+++ 
b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordAction.java
@@ -104,6 +104,6 @@ public class HeartbeatRecordAction {
       return Optional.empty();
     }
     // no new data, finish reading data
-    return cancelQueryOnHeartbeat ? Optional.empty() : 
Optional.of(ProcessContinuation.resume());
+    return cancelQueryOnHeartbeat ? Optional.of(ProcessContinuation.resume()) 
: Optional.empty();
   }
 }
diff --git 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordActionTest.java
 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordActionTest.java
index adfc4ea35d4..48fd7c30a1a 100644
--- 
a/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordActionTest.java
+++ 
b/sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/changestreams/action/HeartbeatRecordActionTest.java
@@ -232,7 +232,7 @@ public class HeartbeatRecordActionTest {
             watermarkEstimator,
             endTimestamp);
 
-    assertEquals(Optional.empty(), maybeContinuation);
+    assertEquals(Optional.of(ProcessContinuation.resume()), maybeContinuation);
     verify(watermarkEstimator).setWatermark(new 
Instant(timestamp.toSqlTimestamp().getTime()));
   }
 
@@ -254,7 +254,7 @@ public class HeartbeatRecordActionTest {
             watermarkEstimator,
             endTimestamp);
 
-    assertEquals(Optional.of(ProcessContinuation.resume()), maybeContinuation);
+    assertEquals(Optional.empty(), maybeContinuation);
     verify(watermarkEstimator).setWatermark(new 
Instant(timestamp.toSqlTimestamp().getTime()));
   }
 }