[
https://issues.apache.org/jira/browse/BEAM-2242?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Luke Cwik updated BEAM-2242:
----------------------------
Description:
javap dump of TextIOTest.class
Not the unshaded references to org.apache.commons.compress.*
{code}
Compiled from "TextIOTest.java"
public class org.apache.beam.sdk.io.TextIOTest {
...
private static java.io.File writeToFile(java.lang.String[], java.lang.String,
org.apache.beam.sdk.io.TextIO$CompressionType) throws java.io.IOException;
descriptor:
([Ljava/lang/String;Ljava/lang/String;Lorg/apache/beam/sdk/io/TextIO$CompressionType;)Ljava/io/File;
Code:
0: getstatic #6 // Field
tempFolder:Ljava/nio/file/Path;
3: aload_1
4: invokeinterface #7, 2 // InterfaceMethod
java/nio/file/Path.resolve:(Ljava/lang/String;)Ljava/nio/file/Path;
9: invokeinterface #8, 1 // InterfaceMethod
java/nio/file/Path.toFile:()Ljava/io/File;
14: astore_3
15: new #9 // class java/io/FileOutputStream
18: dup
19: aload_3
20: invokespecial #10 // Method
java/io/FileOutputStream."<init>":(Ljava/io/File;)V
23: astore 4
25: getstatic #11 // Field
org/apache/beam/sdk/io/TextIOTest$4.$SwitchMap$org$apache$beam$sdk$io$TextIO$CompressionType:[I
28: aload_2
29: invokevirtual #12 // Method
org/apache/beam/sdk/io/TextIO$CompressionType.ordinal:()I
32: iaload
33: tableswitch { // 1 to 5
1: 68
2: 71
3: 85
4: 99
5: 131
default: 145
}
68: goto 157
71: new #13 // class
java/util/zip/GZIPOutputStream
74: dup
75: aload 4
77: invokespecial #14 // Method
java/util/zip/GZIPOutputStream."<init>":(Ljava/io/OutputStream;)V
80: astore 4
82: goto 157
85: new #15 // class
org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream
88: dup
89: aload 4
91: invokespecial #16 // Method
org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream."<init>":(Ljava/io/OutputStream;)V
94: astore 4
96: goto 157
99: new #17 // class
java/util/zip/ZipOutputStream
102: dup
103: aload 4
105: invokespecial #18 // Method
java/util/zip/ZipOutputStream."<init>":(Ljava/io/OutputStream;)V
108: astore 5
110: aload 5
112: new #19 // class java/util/zip/ZipEntry
115: dup
116: ldc #20 // String entry
118: invokespecial #21 // Method
java/util/zip/ZipEntry."<init>":(Ljava/lang/String;)V
121: invokevirtual #22 // Method
java/util/zip/ZipOutputStream.putNextEntry:(Ljava/util/zip/ZipEntry;)V
124: aload 5
126: astore 4
128: goto 157
131: new #23 // class
org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStream
{code}
was:
javap dump of TextIOTest.class
Not the unshaded references to org.apache.commons.compress.*
```
Compiled from "TextIOTest.java"
public class org.apache.beam.sdk.io.TextIOTest {
...
private static java.io.File writeToFile(java.lang.String[], java.lang.String,
org.apache.beam.sdk.io.TextIO$CompressionType) throws java.io.IOException;
descriptor:
([Ljava/lang/String;Ljava/lang/String;Lorg/apache/beam/sdk/io/TextIO$CompressionType;)Ljava/io/File;
Code:
0: getstatic #6 // Field
tempFolder:Ljava/nio/file/Path;
3: aload_1
4: invokeinterface #7, 2 // InterfaceMethod
java/nio/file/Path.resolve:(Ljava/lang/String;)Ljava/nio/file/Path;
9: invokeinterface #8, 1 // InterfaceMethod
java/nio/file/Path.toFile:()Ljava/io/File;
14: astore_3
15: new #9 // class java/io/FileOutputStream
18: dup
19: aload_3
20: invokespecial #10 // Method
java/io/FileOutputStream."<init>":(Ljava/io/File;)V
23: astore 4
25: getstatic #11 // Field
org/apache/beam/sdk/io/TextIOTest$4.$SwitchMap$org$apache$beam$sdk$io$TextIO$CompressionType:[I
28: aload_2
29: invokevirtual #12 // Method
org/apache/beam/sdk/io/TextIO$CompressionType.ordinal:()I
32: iaload
33: tableswitch { // 1 to 5
1: 68
2: 71
3: 85
4: 99
5: 131
default: 145
}
68: goto 157
71: new #13 // class
java/util/zip/GZIPOutputStream
74: dup
75: aload 4
77: invokespecial #14 // Method
java/util/zip/GZIPOutputStream."<init>":(Ljava/io/OutputStream;)V
80: astore 4
82: goto 157
85: new #15 // class
org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream
88: dup
89: aload 4
91: invokespecial #16 // Method
org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream."<init>":(Ljava/io/OutputStream;)V
94: astore 4
96: goto 157
99: new #17 // class
java/util/zip/ZipOutputStream
102: dup
103: aload 4
105: invokespecial #18 // Method
java/util/zip/ZipOutputStream."<init>":(Ljava/io/OutputStream;)V
108: astore 5
110: aload 5
112: new #19 // class java/util/zip/ZipEntry
115: dup
116: ldc #20 // String entry
118: invokespecial #21 // Method
java/util/zip/ZipEntry."<init>":(Ljava/lang/String;)V
121: invokevirtual #22 // Method
java/util/zip/ZipOutputStream.putNextEntry:(Ljava/util/zip/ZipEntry;)V
124: aload 5
126: astore 4
128: goto 157
131: new #23 // class
org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStream
```
> Apache Beam Java modules do not correctly shade test artifacts
> --------------------------------------------------------------
>
> Key: BEAM-2242
> URL: https://issues.apache.org/jira/browse/BEAM-2242
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Blocker
> Fix For: 2.0.0
>
>
> javap dump of TextIOTest.class
> Not the unshaded references to org.apache.commons.compress.*
> {code}
> Compiled from "TextIOTest.java"
> public class org.apache.beam.sdk.io.TextIOTest {
> ...
> private static java.io.File writeToFile(java.lang.String[],
> java.lang.String, org.apache.beam.sdk.io.TextIO$CompressionType) throws
> java.io.IOException;
> descriptor:
> ([Ljava/lang/String;Ljava/lang/String;Lorg/apache/beam/sdk/io/TextIO$CompressionType;)Ljava/io/File;
> Code:
> 0: getstatic #6 // Field
> tempFolder:Ljava/nio/file/Path;
> 3: aload_1
> 4: invokeinterface #7, 2 // InterfaceMethod
> java/nio/file/Path.resolve:(Ljava/lang/String;)Ljava/nio/file/Path;
> 9: invokeinterface #8, 1 // InterfaceMethod
> java/nio/file/Path.toFile:()Ljava/io/File;
> 14: astore_3
> 15: new #9 // class java/io/FileOutputStream
> 18: dup
> 19: aload_3
> 20: invokespecial #10 // Method
> java/io/FileOutputStream."<init>":(Ljava/io/File;)V
> 23: astore 4
> 25: getstatic #11 // Field
> org/apache/beam/sdk/io/TextIOTest$4.$SwitchMap$org$apache$beam$sdk$io$TextIO$CompressionType:[I
> 28: aload_2
> 29: invokevirtual #12 // Method
> org/apache/beam/sdk/io/TextIO$CompressionType.ordinal:()I
> 32: iaload
> 33: tableswitch { // 1 to 5
> 1: 68
> 2: 71
> 3: 85
> 4: 99
> 5: 131
> default: 145
> }
> 68: goto 157
> 71: new #13 // class
> java/util/zip/GZIPOutputStream
> 74: dup
> 75: aload 4
> 77: invokespecial #14 // Method
> java/util/zip/GZIPOutputStream."<init>":(Ljava/io/OutputStream;)V
> 80: astore 4
> 82: goto 157
> 85: new #15 // class
> org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream
> 88: dup
> 89: aload 4
> 91: invokespecial #16 // Method
> org/apache/commons/compress/compressors/bzip2/BZip2CompressorOutputStream."<init>":(Ljava/io/OutputStream;)V
> 94: astore 4
> 96: goto 157
> 99: new #17 // class
> java/util/zip/ZipOutputStream
> 102: dup
> 103: aload 4
> 105: invokespecial #18 // Method
> java/util/zip/ZipOutputStream."<init>":(Ljava/io/OutputStream;)V
> 108: astore 5
> 110: aload 5
> 112: new #19 // class java/util/zip/ZipEntry
> 115: dup
> 116: ldc #20 // String entry
> 118: invokespecial #21 // Method
> java/util/zip/ZipEntry."<init>":(Ljava/lang/String;)V
> 121: invokevirtual #22 // Method
> java/util/zip/ZipOutputStream.putNextEntry:(Ljava/util/zip/ZipEntry;)V
> 124: aload 5
> 126: astore 4
> 128: goto 157
> 131: new #23 // class
> org/apache/commons/compress/compressors/deflate/DeflateCompressorOutputStream
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
