[
https://issues.apache.org/jira/browse/BEAM-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16004180#comment-16004180
]
ASF GitHub Bot commented on BEAM-2241:
--------------------------------------
GitHub user mariapython opened a pull request:
https://github.com/apache/beam/pull/3040
[BEAM-2241] Mark PipelineVisitor and AppliedPTransform as internal
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mariapython/incubator-beam mark_private
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3040.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3040
----
commit 9330c309eb88eec2d352d078e773c97bbe4d7875
Author: [email protected] <[email protected]>
Date: 2017-05-10T06:03:44Z
Mark PipelineVisitor and AppliedPTransform as internal
----
> Correctly mark top level classes and functions as private
> ---------------------------------------------------------
>
> Key: BEAM-2241
> URL: https://issues.apache.org/jira/browse/BEAM-2241
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Chamikara Jayalath
> Assignee: Chamikara Jayalath
> Fix For: 2.0.0
>
>
> Seems like some of the top level classes and function of Python SDK are
> unnecessarily public (does not start with _ ). We should update Python SDK so
> that top level classes and functions that are only used within the
> corresponding modules are private. Additionally, any top level classes and
> functions that are not expected to be used by end-users
> (pipeline/source/ptransform authors) should be clearly documented.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
