Repository: beam Updated Branches: refs/heads/master b1382969b -> 6dc39cd35
Remove Timer.cancel() from user-facing API Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/c755921f Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/c755921f Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/c755921f Branch: refs/heads/master Commit: c755921f42cb460ba2cf4933cc1f771eb971f6bc Parents: b138296 Author: Kenneth Knowles <[email protected]> Authored: Tue May 9 20:46:43 2017 -0700 Committer: Kenneth Knowles <[email protected]> Committed: Wed May 10 09:21:36 2017 -0700 ---------------------------------------------------------------------- .../java/org/apache/beam/runners/core/SimpleDoFnRunner.java | 5 ----- .../core/src/main/java/org/apache/beam/sdk/state/Timer.java | 6 ------ 2 files changed, 11 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/c755921f/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java index aab34a5..85423c0 100644 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java +++ b/runners/core-java/src/main/java/org/apache/beam/runners/core/SimpleDoFnRunner.java @@ -988,11 +988,6 @@ public class SimpleDoFnRunner<InputT, OutputT> implements DoFnRunner<InputT, Out timerInternals.setTimer(namespace, timerId, target, spec.getTimeDomain()); } - @Override - public void cancel() { - timerInternals.deleteTimer(namespace, timerId); - } - private Instant getCurrentTime() { switch(spec.getTimeDomain()) { case EVENT_TIME: http://git-wip-us.apache.org/repos/asf/beam/blob/c755921f/sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java index 6f98ff8..43196a4 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/state/Timer.java @@ -54,12 +54,6 @@ public interface Timer { void set(Instant absoluteTime); /** - * Unsets this timer. It is permitted to {@code cancel()} whether or not the timer was actually - * set. - */ - void cancel(); - - /** * Sets the timer relative to the current time, according to any offset and alignment specified. * Using {@link #offset(Duration)} and {@link #align(Duration)}. */
