[
https://issues.apache.org/jira/browse/BEAM-2052?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16005296#comment-16005296
]
ASF GitHub Bot commented on BEAM-2052:
--------------------------------------
GitHub user jkff opened a pull request:
https://github.com/apache/beam/pull/3060
[BEAM-2052] Cherrypick #3023 and #3059 to release-2.0.0
#3023 implements the functionality, #3059 fixes the build breakage :-|
R: @davorbonaci OR @dhalperi
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jkff/incubator-beam cp-windowed-writes
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3060.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3060
----
commit 213eef8bc835c9fa85333356b413cb5886987ba7
Author: Eugene Kirpichov <[email protected]>
Date: 2017-05-10T19:18:47Z
This closes #3023
commit ede0e3ba00c2bd380738e92002f437cada0f0510
Author: Eugene Kirpichov <[email protected]>
Date: 2017-05-10T19:30:24Z
This closes #3059
----
> Windowed file sinks should support dynamic sharding
> ---------------------------------------------------
>
> Key: BEAM-2052
> URL: https://issues.apache.org/jira/browse/BEAM-2052
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Reuven Lax
> Assignee: Reuven Lax
> Fix For: 2.0.0
>
>
> Currently windowed file sinks (WriteFiles and FileBasedSink) require
> withNumShards to be set explicitly. We should remove this requirement, and
> allow dynamic output.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
