[
https://issues.apache.org/jira/browse/BEAM-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008772#comment-16008772
]
ASF GitHub Bot commented on BEAM-2024:
--------------------------------------
GitHub user aaltay opened a pull request:
https://github.com/apache/beam/pull/3128
[BEAM-2024] internal comments
R: @robertwb
cc: @davorbonaci (comment only change, if we can pick to the release
branch, it is ok if it is too late.)
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/aaltay/beam after
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3128.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3128
----
commit db36b6342d8c347ca455447a5c428da9b0b33f4a
Author: Ahmet Altay <[email protected]>
Date: 2017-05-12T21:54:33Z
internal comments
----
> Python and Java Dataflow refer to AfterCount, but Java Beam does not have
> AfterCount
> ------------------------------------------------------------------------------------
>
> Key: BEAM-2024
> URL: https://issues.apache.org/jira/browse/BEAM-2024
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Wesley Tanaka
> Assignee: Ahmet Altay
> Priority: Minor
>
> * https://cloud.google.com/dataflow/model/triggers#window-accumulation-modes
> refers to an AfterCount trigger
> * There is no AfterCount trigger in java SDK
> * There is an AfterCount trigger in python SDK
> My wild guess hypothesis is that AfterCount got renamed between Dataflow and
> Beam, but that the python beam SDK did not also execute the same rename?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
