[
https://issues.apache.org/jira/browse/BEAM-2024?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16008840#comment-16008840
]
Robert Bradshaw edited comment on BEAM-2024 at 5/12/17 10:39 PM:
-----------------------------------------------------------------
Note also that we have the more concise AfterWatermark(early=..., late=...)
rather than
AfterWatermark.pastEndOfWindow().withEarlyFirings(...).withLateFirings(...) and
just use AfterEach(...) rather than AfterEach.inOrder(...). This is in large
part due to Java's use of static method + builder pattern, rather than
constructor-with-keyword-arguments style.
I don't think we need to make Python as verbose as Java. (And other languages
like Go may prefer brevity as well.)
was (Author: robertwb):
Note also that we have the more concise AfterWatermark(early=..., late=...)
rather than
AfterWatermark.pastEndOfWindow().withEarlyFirings(...).withLateFirings(...) and
just use AfterEach(...) rather than AfterEach.inOrder(...). This is in large
part due to Java's use of static method + builder pattern, rather than
constructor-with-keyword-arguments style.
> Python and Java SDKs differ on name of AfterCount
> -------------------------------------------------
>
> Key: BEAM-2024
> URL: https://issues.apache.org/jira/browse/BEAM-2024
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py
> Reporter: Wesley Tanaka
> Assignee: Ahmet Altay
> Priority: Minor
>
> * https://cloud.google.com/dataflow/model/triggers#window-accumulation-modes
> refers to an AfterCount trigger
> * There is no AfterCount trigger in java SDK
> * There is an AfterCount trigger in python SDK
> My wild guess hypothesis is that AfterCount got renamed between Dataflow and
> Beam, but that the python beam SDK did not also execute the same rename?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
