[
https://issues.apache.org/jira/browse/BEAM-2234?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16009124#comment-16009124
]
ASF GitHub Bot commented on BEAM-2234:
--------------------------------------
GitHub user XuMingmin opened a pull request:
https://github.com/apache/beam/pull/3135
[BEAM-2234] expose PCollection of each RelNode
Change the return of `buildBeamPipeline` to `PCollection<BeamSQLRow>`, this
helps to:
1). donot need to manage the upstream-downstream in `BeamPipelineCreator`
as execution tree already have it;
2). easy for unit test with `PAssert`;
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XuMingmin/beam BEAM-2234
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3135.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3135
----
commit ebd263c9e29515038b1ee00dc423da44bef65362
Author: mingmxu <ming...@ebay.com>
Date: 2017-05-13T04:14:29Z
change return type of buildBeamPipeline to `PCollection<BeamSQLRow>`
----
> expose PCollection of each RelNode
> ----------------------------------
>
> Key: BEAM-2234
> URL: https://issues.apache.org/jira/browse/BEAM-2234
> Project: Beam
> Issue Type: Task
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
>
> Change the return of {{buildBeamPipeline}} to {{PCollection<BeamSQLRow>}},
> this helps to:
> 1). donot need to manage the upstream-downstream as execution tree already
> have it;
> 2). easy for unit test with {{PAssert}};
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
