[
https://issues.apache.org/jira/browse/BEAM-2276?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16010321#comment-16010321
]
ASF GitHub Bot commented on BEAM-2276:
--------------------------------------
GitHub user hepeknet opened a pull request:
https://github.com/apache/beam/pull/3142
[BEAM-2276] make it easier to specify windowed filename policy
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-2276] make it easier to specify windowed filename policy`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
@dhalperi @jbonofre @reuvenlax
this is probably better than just throwing exception. This way full
compatibility (no need to specify windowing template). Also, users can always
specify their own policy in case they need more control.
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hepeknet/beam BEAM-2276
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3142.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3142
----
commit d1034ae48fe9c52546d8a67d20cc5472e2b98e28
Author: Borisa Zivkovic <[email protected]>
Date: 2017-05-15T07:56:19Z
adding windowing into default filename policy
commit a5ce4966584ef2fc6cfa87b33c38b852ae223ab6
Author: Borisa Zivkovic <[email protected]>
Date: 2017-05-15T10:30:19Z
adding windowed file naming policy to DefaultFileNamePolicy
----
> make it easier to specify windowed filename policy
> --------------------------------------------------
>
> Key: BEAM-2276
> URL: https://issues.apache.org/jira/browse/BEAM-2276
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Borisa Zivkovic
> Assignee: Borisa Zivkovic
>
> It should be easier for Beam users to specify filename policy which
> understands windowing concepts.
> Discussion here
> https://lists.apache.org/thread.html/b53e437894eb511c9161d34fc77c657300b77a7be75f0fab6566b3d6@%3Cdev.beam.apache.org%3E
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
