GitHub user dhalperi opened a pull request:
https://github.com/apache/beam/pull/3146
[BEAM-1542] Takeover #2166 with initial support for SpannerIO.Write
This takes over #2166, and it is not really ready for use. To be properly
ready, it needs:
* Many style guide fixes.
* Comprehensive javadoc.
* Unit tests and integration tests.
However, given that 2.0.0 was just cut and there is a month until next
release, I believe it should be okay to merge this as @mairbek and
@NextDevBoard are actively working on it.
We will pull it from the 2.1.0 release if these major issues are not
addressed before then.
R: @davorbonaci
CC: @mairbek @nextdevboard
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dhalperi/beam takeover-2166
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3146.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3146
----
commit 4392de9be272c045a9854340f887e420f25f0f4a
Author: MOLIG004 <[email protected]>
Date: 2017-05-04T16:21:23Z
Initial implementation of SpannerIO.Write
This closes #2166.
commit b092be8df5cd96012c4d67b3defbd3554707edfe
Author: Dan Halperin <[email protected]>
Date: 2017-05-04T17:42:07Z
Minor style, compilation, javadoc fixups
commit e16339a3e699d7bea30f3f3a703b4c7c3ead0f59
Author: Dan Halperin <[email protected]>
Date: 2017-05-04T17:48:54Z
Fix spanner dependency management
Also minor cleanup alphabetization in root pom.xml
commit 9798534793286aeb3deacdc0e30f63032b6077fe
Author: Dan Halperin <[email protected]>
Date: 2017-05-04T17:48:24Z
Delete SpannerCSVLoader
This is not appropriate for examples. SpannerIO should be well-javadoced
and integration tested.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
