[
https://issues.apache.org/jira/browse/BEAM-1663?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16011221#comment-16011221
]
ASF GitHub Bot commented on BEAM-1663:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3151
[BEAM-1663] Use stable naming strategy for ByteBuddy invokers
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
This helps to coalesce related failures across multiple JVM instances, over
time, across machines, etc.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam bytebuddy-names
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3151.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3151
----
commit 515c0c846c63e5a05d792ce3b8c60aaa4acdd382
Author: Kenneth Knowles <[email protected]>
Date: 2017-03-09T01:02:05Z
Use stable naming strategy for ByteBuddy invokers
This helps to coalesce related failures across multiple
JVM instances, over time, across machines, etc.
----
> Generated package names should be deterministic and consistent across runs.
> ---------------------------------------------------------------------------
>
> Key: BEAM-1663
> URL: https://issues.apache.org/jira/browse/BEAM-1663
> Project: Beam
> Issue Type: Improvement
> Components: runner-core, sdk-java-core
> Reporter: Alex Amato
> Assignee: Kenneth Knowles
>
> This makes it difficult for error/stack trace processing systems to identify
> that these two errors are the same.
> These two errors contain generated package names with random strings in them,
> would it be possible to make the generated package names consistent across
> each job run? From what I understand the random string is to prevent two
> package names from colliding. Perhaps we could have the name be of the
> generated packages be based off the functions they are wrapping/referring to?
> YZjse2Tt
> 1TK4aKgJ
> src.test.java.org.apache.beam.examples.cookbook.LoggedException:
> LoggedException
> at
> src.test.java.org.apache.beam.examples.cookbook.CloudErrorReporting$WriteLogs$1.processElement
> (CloudErrorReporting.java:94)
> at
> src.test.java.org.apache.beam.examples.cookbook.CloudErrorReporting$WriteLogs$1$auxiliary$1TK4aKgJ.invokeProcessElement
> (Unknown Source)
> ---
> src.test.java.org.apache.beam.examples.cookbook.LoggedException:
> LoggedException
> at
> src.test.java.org.apache.beam.examples.cookbook.CloudErrorReporting$WriteLogs$1.processElement
> (CloudErrorReporting.java:94)
> at
> src.test.java.org.apache.beam.examples.cookbook.CloudErrorReporting$WriteLogs$1$auxiliary$YZjse2Tt.invokeProcessElement
> (Unknown Source)
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
