[
https://issues.apache.org/jira/browse/BEAM-2164?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16014809#comment-16014809
]
ASF GitHub Bot commented on BEAM-2164:
--------------------------------------
GitHub user markflyhigh opened a pull request:
https://github.com/apache/beam/pull/3171
[BEAM-2164] Fix generate-sources.sh if directory contains space
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
[generate-sources.sh](https://github.com/apache/beam/blob/master/sdks/java/maven-archetypes/examples/generate-sources.sh)
is executed in beam-sdks-java-maven-archetypes-examples and
beam-sdks-java-maven-archetypes-examples-java8. If project directory contains
space, mvn build of the two module will fail because the space character is not
handled properly.
Test is done by successfully running mvn clean build.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/markflyhigh/incubator-beam
fix-generate-sources
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3171.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3171
----
commit e8bc4f994e10b0d70f3e1123904360d5fb45c3b3
Author: Mark Liu <[email protected]>
Date: 2017-05-17T21:24:25Z
[BEAM-2164] Fix generate-sources.sh if directory contains space
----
> Build beam-sdks-java-maven-archetypes-examples Failed If Dir Contains Space
> ---------------------------------------------------------------------------
>
> Key: BEAM-2164
> URL: https://issues.apache.org/jira/browse/BEAM-2164
> Project: Beam
> Issue Type: Bug
> Components: build-system, sdk-java-extensions
> Reporter: Mark Liu
> Assignee: Mark Liu
>
> Error log from [Jenkins console
> log|https://builds.apache.org/job/beam_PostCommit_Java_JDK_Versions_Test/jdk=JDK%201.8%20(latest),label=beam/6/console]:
> {code}
> rsync: change_dir
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_JDK_Versions_Test/jdk\#012.\#012(latest)/label/beam/sdks/java/maven-archetypes/examples/../../../../examples/java/src/main/java/org/apache/beam/examples"
> failed: No such file or directory (2)
> rsync error: some files/attrs were not transferred (see previous errors)
> (code 23) at main.c(1183) [sender=3.1.0]
> 2017-05-03\T\19:20:56.905 [ERROR] Command execution failed.
> {code}
> beam-sdks-java-maven-archetypes-examples execute a [bash
> script|https://github.com/apache/beam/blob/master/sdks/java/maven-archetypes/examples/generate-sources.sh]
> through
> [exec-maven-plugin|https://github.com/apache/beam/blob/master/sdks/java/maven-archetypes/examples/pom.xml#L79].
> Looks like it fails to create a directory which contains space in [previous
> step|https://github.com/apache/beam/blob/master/sdks/java/maven-archetypes/examples/generate-sources.sh#L32].
> The root directory of above build is
> "/home/jenkins/jenkins-slave/workspace/beam_PostCommit_Java_JDK_Versions_Test/jdk/JDK
> 1.8 (latest)/label/beam/...".
> Similar error also happens in
> [JDK1.7|https://builds.apache.org/job/beam_PostCommit_Java_JDK_Versions_Test/jdk=JDK%201.7%20(latest),label=beam/8/]
> and
> [OpenJDK7|https://builds.apache.org/job/beam_PostCommit_Java_JDK_Versions_Test/jdk=OpenJDK%207%20(on%20Ubuntu%20only),label=beam/8/].
> I simply run
> [generate-sources.sh|https://github.com/apache/beam/blob/master/sdks/java/maven-archetypes/examples/generate-sources.sh]
> from my Linux machine in JDK1.8 under contain-space directory and it works
> perfectly. I guess exec-maven-plugin works differently when handling bash
> commands that contains space, but I failed to solve this problem by modifying
> commands in script.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
