Delete unused BaseStepContext
Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/62115b29 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/62115b29 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/62115b29 Branch: refs/heads/master Commit: 62115b29a7f27a1a74b7c870d4277655adb3dfbf Parents: dc58551 Author: Kenneth Knowles <[email protected]> Authored: Mon May 22 17:46:58 2017 -0700 Committer: Kenneth Knowles <[email protected]> Committed: Tue May 23 11:16:27 2017 -0700 ---------------------------------------------------------------------- .../beam/runners/core/BaseStepContext.java | 40 -------------------- .../beam/runners/core/SimpleDoFnRunnerTest.java | 2 +- .../runners/core/StatefulDoFnRunnerTest.java | 2 +- .../runners/direct/DirectExecutionContext.java | 3 -- 4 files changed, 2 insertions(+), 45 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/62115b29/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java b/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java deleted file mode 100644 index 4abd4d2..0000000 --- a/runners/core-java/src/main/java/org/apache/beam/runners/core/BaseStepContext.java +++ /dev/null @@ -1,40 +0,0 @@ -/* - * Licensed to the Apache Software Foundation (ASF) under one - * or more contributor license agreements. See the NOTICE file - * distributed with this work for additional information - * regarding copyright ownership. The ASF licenses this file - * to you under the Apache License, Version 2.0 (the - * "License"); you may not use this file except in compliance - * with the License. You may obtain a copy of the License at - * - * http://www.apache.org/licenses/LICENSE-2.0 - * - * Unless required by applicable law or agreed to in writing, software - * distributed under the License is distributed on an "AS IS" BASIS, - * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. - * See the License for the specific language governing permissions and - * limitations under the License. - */ -package org.apache.beam.runners.core; - -/** - * Base class for implementations of {@link StepContext}. - * - * <p>To complete a concrete subclass, implement {@link #timerInternals} and - * {@link #stateInternals}. - */ -public abstract class BaseStepContext implements StepContext { - private final String stepName; - private final String transformName; - - public BaseStepContext(String stepName, String transformName) { - this.stepName = stepName; - this.transformName = transformName; - } - - @Override - public abstract StateInternals stateInternals(); - - @Override - public abstract TimerInternals timerInternals(); -} http://git-wip-us.apache.org/repos/asf/beam/blob/62115b29/runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java b/runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java index 59e5857..f331b65 100644 --- a/runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java +++ b/runners/core-java/src/test/java/org/apache/beam/runners/core/SimpleDoFnRunnerTest.java @@ -63,7 +63,7 @@ public class SimpleDoFnRunnerTest { @Rule public ExpectedException thrown = ExpectedException.none(); @Mock - BaseStepContext mockStepContext; + StepContext mockStepContext; @Mock TimerInternals mockTimerInternals; http://git-wip-us.apache.org/repos/asf/beam/blob/62115b29/runners/core-java/src/test/java/org/apache/beam/runners/core/StatefulDoFnRunnerTest.java ---------------------------------------------------------------------- diff --git a/runners/core-java/src/test/java/org/apache/beam/runners/core/StatefulDoFnRunnerTest.java b/runners/core-java/src/test/java/org/apache/beam/runners/core/StatefulDoFnRunnerTest.java index 62a6578..4f155dc 100644 --- a/runners/core-java/src/test/java/org/apache/beam/runners/core/StatefulDoFnRunnerTest.java +++ b/runners/core-java/src/test/java/org/apache/beam/runners/core/StatefulDoFnRunnerTest.java @@ -69,7 +69,7 @@ public class StatefulDoFnRunnerTest { new IntervalWindow(new Instant(10), new Instant(20)); @Mock - BaseStepContext mockStepContext; + StepContext mockStepContext; private InMemoryStateInternals<String> stateInternals; private InMemoryTimerInternals timerInternals; http://git-wip-us.apache.org/repos/asf/beam/blob/62115b29/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java ---------------------------------------------------------------------- diff --git a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java index 8452565..cca5719 100644 --- a/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java +++ b/runners/direct-java/src/main/java/org/apache/beam/runners/direct/DirectExecutionContext.java @@ -17,11 +17,8 @@ */ package org.apache.beam.runners.direct; -import java.util.Collection; -import java.util.Collections; import java.util.LinkedHashMap; import java.util.Map; -import org.apache.beam.runners.core.BaseStepContext; import org.apache.beam.runners.core.StepContext; import org.apache.beam.runners.core.TimerInternals; import org.apache.beam.runners.direct.WatermarkManager.TimerUpdate;
