[
https://issues.apache.org/jira/browse/BEAM-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16031803#comment-16031803
]
ASF GitHub Bot commented on BEAM-2246:
--------------------------------------
Github user asfgit closed the pull request at:
https://github.com/apache/beam/pull/3073
> JmsIO should use CLIENT_ACK instead of AUTO_ACK
> -----------------------------------------------
>
> Key: BEAM-2246
> URL: https://issues.apache.org/jira/browse/BEAM-2246
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-extensions
> Affects Versions: 0.6.0
> Reporter: Jean-Baptiste Onofré
> Assignee: Jean-Baptiste Onofré
>
> As {{JmsIO}} manages the messages acknowledgement in its checkpoint, it
> should not use {{AUTO_ACKNOWLEDGE}} but {{CLIENT_ACKNOWLEDGE}}.
> With {{AUTO_ACK}}, the ack is sent to the JMS broker as soon as the message
> is consumed. Basically, it means that the checkpoint is useless as, if
> something goes wrong in the pipeline, the messages is already consumed from
> the broker (so no way to redeliver the message).
> Instead, {{JmsIO}} should use {{CLIENT_ACK}} and explicitly send the ack
> (commit) in the checkpoint (the code is already in place).
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
