[ https://issues.apache.org/jira/browse/BEAM-2402?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16034113#comment-16034113 ]
Robert Bradshaw commented on BEAM-2402: --------------------------------------- If an existing trigger has the correct semantics but poor performance, I'd rather see the performance issues addressed than introducing a new trigger (especially as triggers are not UDFs). Short of the fact that it will never fire unless an element comes in, is this jsut Repeatedly(AfterFirst(ElementCount, AfterProcessingTime))? > Support AfterPane.elementGapAtMost() trigger and its combination with > elementCountAtLeast() > ------------------------------------------------------------------------------------------- > > Key: BEAM-2402 > URL: https://issues.apache.org/jira/browse/BEAM-2402 > Project: Beam > Issue Type: New Feature > Components: sdk-java-core > Reporter: Pei He > Assignee: Pei He > > We need a timestamp-driven trigger to use as a cheaper (or more efficient) > version of the ProcessingTime trigger. > The problem of using ProcessingTime trigger is that current runners' supports > are not very efficient, and couldn't work for pipelines that have lots of > keys (for example, flink runner will scan timers for all keys when watermark > advance). > We have used AfterPane.elementGapAtMost() trigger in our production, and want > to merge it back. And, we believe it could be the solution for people who > have the similar issue. > Implementation for reference: > https://github.com/apache/beam/compare/master...peihe:custom-after-pane?expand=1 -- This message was sent by Atlassian JIRA (v6.3.15#6346)