[
https://issues.apache.org/jira/browse/BEAM-2392?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16037687#comment-16037687
]
Luke Cwik commented on BEAM-2392:
---------------------------------
Looking at the generated source for *clone*, it seems like using it here is not
a big win in anyway as its short hand for *newBuilder()+merge(existing
proto/builder)*. Seems like we could take the change that you are suggesting.
Mind opening up a PR?
I also noticed that DatastoreV1Test.java and V1TestUtil.java both use proto
clone.
> Avoid use of proto builder clone
> --------------------------------
>
> Key: BEAM-2392
> URL: https://issues.apache.org/jira/browse/BEAM-2392
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Affects Versions: 2.1.0
> Reporter: Nigel Kilmer
> Assignee: Nigel Kilmer
> Priority: Minor
>
> BigtableServiceImpl uses the clone method of the MutateRowResponse proto
> builder here:
> https://github.com/apache/beam/blob/04e3261818aed0c129e7c715e371463bf5b5c1b8/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigtable/BigtableServiceImpl.java#L212
> This method is not generated by the Google-internal Java proto generator, so
> I had to change this to get it to work with an internal project. Are you
> interested in adding this change to the main repository for compatibility, or
> would you prefer to keep the cleaner version that uses clone?
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
