[
https://issues.apache.org/jira/browse/BEAM-2282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16043254#comment-16043254
]
Tarush Grover commented on BEAM-2282:
-------------------------------------
[~mingmxu] currently accept function in BeamSqlExpression is not called during
a sql query but it directs to calcite validation and in that it calls its
`accept` function. Is my understanding correct?
> logic in function accept in BeamSqlExpression
> ---------------------------------------------
>
> Key: BEAM-2282
> URL: https://issues.apache.org/jira/browse/BEAM-2282
> Project: Beam
> Issue Type: Improvement
> Components: dsl-sql
> Reporter: Xu Mingmin
>
> Method {{accept}} is used to make sure the SQL operator is supported in Beam
> SQL. IMO it should only check the case that some scenarios are not supported
> in BeamSQL even it's valid in Calcite SQL grammar.
> It's not necessary to my understand to validate SQL grammar as that's done
> already in the parsing phase.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
