GitHub user tgroh opened a pull request:
https://github.com/apache/beam/pull/3345
Cleanups to CombineTest
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tgroh/beam combine_context_cleanup
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3345.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3345
----
commit bf71c13a94e7a87156ba3c912e0e2d49e388368c
Author: Thomas Groh <[email protected]>
Date: 2017-06-12T18:07:47Z
Inline Values in CombineTest with Sessions and Context
commit 14ef888a27230697d52b90089ff80aa0e88a190c
Author: Thomas Groh <[email protected]>
Date: 2017-06-12T20:47:39Z
Cleanup Combine Tests with Context
Split out the "shared" bit of all of the accumulators. Update some
creation logic.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
