[
https://issues.apache.org/jira/browse/BEAM-1282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16050453#comment-16050453
]
ASF GitHub Bot commented on BEAM-1282:
--------------------------------------
GitHub user rfevang opened a pull request:
https://github.com/apache/beam/pull/3367
[BEAM-1282] Support @FinishBundle output in DoFnTester
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/rfevang/beam
dofntester-support-finishbundle-output
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3367.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3367
----
commit e9354f1538da0293a5fc40e9110db54ee80bc819
Author: Rune Fevang <[email protected]>
Date: 2017-06-15T11:51:12Z
Add test for finish bundle output.
commit bb31f77faecdfb75f748af9ca4e912ca5461c2f6
Author: Rune Fevang <[email protected]>
Date: 2017-06-15T12:28:02Z
Allow output from FinishBundle in DoFnTester
----
> DoFnTester should allow output() calls in start/finishBundle
> ------------------------------------------------------------
>
> Key: BEAM-1282
> URL: https://issues.apache.org/jira/browse/BEAM-1282
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Daniel Mills
> Priority: Minor
> Labels: starter
>
> In a DoFn, users can call output() or outputWithTimestamp() during
> start/finishBundle. This will attempt to deduce a window for the output
> element based on the current WindowFn and any timestamp provided. However,
> DoFnTester always throws an exception if these methods are called from
> start/finishBundle (because it does not have a WindowFn, so that will have to
> be enhanced)
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
