[
https://issues.apache.org/jira/browse/BEAM-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16056627#comment-16056627
]
ASF GitHub Bot commented on BEAM-2482:
--------------------------------------
GitHub user evindj opened a pull request:
https://github.com/apache/beam/pull/3406
[BEAM-2482] CodedValueMutationDetector should use the coders structural
value
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/evindj/beam Beam2482
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3406.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3406
----
commit a501deb8d7d20dc1d2bcd17485fec4e77e7dbd84
Author: = <=>
Date: 2017-06-15T00:11:49Z
removed OnceTrigger from TriggerStateMachine implementation
commit 3c92a1f27b9e93273a39e6100092129b0afc3f00
Author: = <=>
Date: 2017-06-15T01:02:07Z
set firing termination indicator where relevant
commit 8f827cc9f871308567783308fa7dca559354e58e
Author: = <=>
Date: 2017-06-19T22:56:29Z
Merge branch 'master' of https://github.com/apache/beam into BEAM-765
commit cdb8a2ad624748843195a35a9014acc21d9a672a
Author: = <=>
Date: 2017-06-20T21:57:12Z
Merge branch 'master' of https://github.com/apache/beam into BEAM-765
commit 02088c85409388f857f173c3beb17bda7e0b74f3
Author: = <=>
Date: 2017-06-20T23:00:19Z
Mutability verification to be based on coder's structural value rather
than encoded- decoded byte arrays
----
> CodedValueMutationDetector should use the coders structural value
> -----------------------------------------------------------------
>
> Key: BEAM-2482
> URL: https://issues.apache.org/jira/browse/BEAM-2482
> Project: Beam
> Issue Type: Improvement
> Components: runner-direct
> Reporter: Luke Cwik
> Assignee: Innocent
> Priority: Minor
> Labels: newbie, starter
>
> Currently the CodedValueMutationDetector[1] checks to see if the objects are
> Java equals and then compares whether the bytes are equal. Instead of relying
> on the bytes, we should rely on the coders structural value explicitly[2].
> This allows for a coder to provide a fast path equality check with the
> default still comparing byte array representations.
> 1:
> https://github.com/apache/beam/blob/eae0d05bd7c088accd927dcfe3e511efbb11c9fd/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java
> 2:
> https://github.com/apache/beam/blob/01b3f87f977d44eac23eb5488074bbc638858a9d/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java#L252
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
