[
https://issues.apache.org/jira/browse/BEAM-2509?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16064104#comment-16064104
]
ASF GitHub Bot commented on BEAM-2509:
--------------------------------------
GitHub user vikkyrk opened a pull request:
https://github.com/apache/beam/pull/3445
[BEAM-2509}] Enable grpc controller in fn_api_runner
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/vikkyrk/incubator-beam fn_api_runner_test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3445.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3445
----
commit 556d291bc3154695450ac18076c82cccc790ecb7
Author: Vikas Kedigehalli <[email protected]>
Date: 2017-06-27T01:47:39Z
Enable grpc controller in fn_api_runner
----
> Fn API Runner hangs in grpc controller mode
> -------------------------------------------
>
> Key: BEAM-2509
> URL: https://issues.apache.org/jira/browse/BEAM-2509
> Project: Beam
> Issue Type: Bug
> Components: beam-model-fn-api, sdk-py
> Reporter: Vikas Kedigehalli
> Assignee: Luke Cwik
> Priority: Minor
>
> https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/portability/fn_api_runner.py#L312
> tests only run in direct mode, but we should run in grpc mode as well.
> Currently the grpc mode is broken and needs fixing. Once we enable it, these
> tests can catch issues like https://github.com/apache/beam/pull/3431
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
