[
https://issues.apache.org/jira/browse/BEAM-2272?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16070991#comment-16070991
]
ASF GitHub Bot commented on BEAM-2272:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3488
[BEAM-2272] Run dependency analysis on all maven lifecycle phases
In this way, tests can also have IWYU enforced. The number of
runtime-only and provided dependencies should be very small so the
burden of adding exclusions with commentary should be insignificant.
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
We have had enough issues with test dependencies that we should lock down
all kinds of dependencies as explicitly as possible.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam mdep
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3488.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3488
----
commit 4c703a32c960caa0e3c0c9b430007bb2b12a2774
Author: Kenneth Knowles <[email protected]>
Date: 2017-07-01T04:14:47Z
Run dependency analysis on all maven lifecycle phases
In this way, tests can also have IWYU enforced. The number of
runtime-only and provided dependencies should be very small so the
burden of adding exclusions with commentary should be insignificant.
----
> Test scope & runtime dependencies need reevaluation
> ---------------------------------------------------
>
> Key: BEAM-2272
> URL: https://issues.apache.org/jira/browse/BEAM-2272
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow, runner-direct, sdk-java-core
> Reporter: Daniel Halperin
> Assignee: Kenneth Knowles
> Fix For: 2.1.0
>
>
> Now that SDK core has been thinned out, many of the modules that have it in
> their {{dependenciesToScan}} will need to update their test-scoped
> dependencies for things that moved out of SDK.
> Known examples include protobuf and XML and perhaps others.
> We should re-enable dependency analysis on test scope and manually validate
> and ignore specific known runtime/test-runtime dependencies.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
