[ 
https://issues.apache.org/jira/browse/BEAM-2505?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16077231#comment-16077231
 ] 

ASF GitHub Bot commented on BEAM-2505:
--------------------------------------

GitHub user kennknowles opened a pull request:

    https://github.com/apache/beam/pull/3511

    [BEAM-2505, BEAM-2502] Fixes to ReduceFnRunner.onTimers (cherry pick to 
release-2.1.0)

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [ ] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [ ] Make sure tests pass via `mvn clean verify`.
     - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [ ] If this contribution is large, please file an Apache
           [Individual Contributor License 
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    R: @jbonofre this cherry picks #3429 to the release branch. Please compare 
and merge when satisfied.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/kennknowles/beam cherry-pick-3429

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3511.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3511
    
----
commit 3d7b00983d2ef215639c3fefc3d8df487aac7b2e
Author: Kenneth Knowles <[email protected]>
Date:   2017-06-23T01:09:11Z

    Ignore processing time timers in expired windows

commit b1e53d6d87a14e3116f996d44b14540b6b7bfa59
Author: Kenneth Knowles <[email protected]>
Date:   2017-06-23T01:43:39Z

    Process timer firings for a window together

----


> When EOW != GC and the timers fire in together, the output is not marked as 
> the final pane
> ------------------------------------------------------------------------------------------
>
>                 Key: BEAM-2505
>                 URL: https://issues.apache.org/jira/browse/BEAM-2505
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-core
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>             Fix For: 2.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to