GitHub user echauchot opened a pull request:
https://github.com/apache/beam/pull/3517
[BEAM-2499] Make SparkAbstractCombineFn generic to allow merging custom
windows
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [X] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [X] Make sure tests pass via `mvn clean verify`.
- [X] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [X] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @amitsela
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/echauchot/beam BEAM-2499-interval_window_cast
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3517.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3517
----
commit a23b73a10fd7891b8eb3fe0d57ce22dc428ca51e
Author: Etienne Chauchot <[email protected]>
Date: 2017-05-29T10:05:51Z
[BEAM-2314] Add ValidatesRunner test for merging custom windows
commit 47aa570a312a1051d544bb1c17e165f31fd63117
Author: Etienne Chauchot <[email protected]>
Date: 2017-07-06T12:31:26Z
[BEAM-2499] Make SparkAbstractCombineFn generic to allow merging custom
windows
commit 0a18986f06e3027278aca3176057d1b8e7b59100
Author: Etienne Chauchot <[email protected]>
Date: 2017-07-07T15:34:23Z
Remove exclusion of UsesCustomWindowMerging of Spark validatesRunner tests,
now that Spark supports it
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
