[
https://issues.apache.org/jira/browse/BEAM-2557?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16078418#comment-16078418
]
ASF GitHub Bot commented on BEAM-2557:
--------------------------------------
GitHub user kennknowles opened a pull request:
https://github.com/apache/beam/pull/3518
[BEAM-2557] Move DirectRunner knob out of core SDK (Cherry pick for 2.1.0)
… of core SDK
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [ ] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [ ] Make sure tests pass via `mvn clean verify`.
- [ ] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [ ] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @jbonofre this is a cherry -pick of #3516
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/kennknowles/beam DirectRunner-WriteFiles-2.1.0
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3518.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3518
----
commit fbf69c8d95d7e148c06b1d99eac28de42c33a9a4
Author: Kenneth Knowles <[email protected]>
Date: 2017-07-07T15:49:08Z
Move DirectRunner knob for suppressing runner-determined sharding out of
core SDK
----
> DirectRunner should not have a hard dependency on Hamcrest
> ----------------------------------------------------------
>
> Key: BEAM-2557
> URL: https://issues.apache.org/jira/browse/BEAM-2557
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Reporter: Kenneth Knowles
> Assignee: Kenneth Knowles
> Priority: Blocker
> Fix For: 2.1.0
>
>
> It seems that https://github.com/apache/beam/pull/3161/files introduced a
> hard dependency from the DirectRunner to TestPipelineOptions. But those
> options are only really appropriate for test scope - they incur a hard
> dependency on Hamcrest. From what I can tell, you really just want to tweak
> the DirectRunner behavior so the one flag could go in DirectPipelineOptions.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
