[
https://issues.apache.org/jira/browse/BEAM-2606?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16084312#comment-16084312
]
Kenneth Knowles commented on BEAM-2606:
---------------------------------------
Sounds good to me. Many WindowFn implementations don't actually care about the
element, so it is kind of nice to also leave the current methods for
convenience.
> WindowFnTestUtils should allow using the value in addition to the timestamp
> of the elements
> -------------------------------------------------------------------------------------------
>
> Key: BEAM-2606
> URL: https://issues.apache.org/jira/browse/BEAM-2606
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-core
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
>
> {{WindowFnTestUtils}} relies only on timeStamps for everything related to
> windows assignment in the test helpers. But when creating a custom
> {{WindowFn}} (and most likely CustomWindow as well), that {{WindowFn}} might
> rely on element value in addition to timestamp to decide the windows that
> will be assigned to the element. To be able to test this kind of custom
> WindowFn, we need versions of the helper methods in WindowFnTestUtils that
> allow passing {{TimeStampedValues}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
