Fix null checks in TransformHierarchy
Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/83f31e94 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/83f31e94 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/83f31e94 Branch: refs/heads/DSL_SQL Commit: 83f31e942b5e106b21bc922d016c5840bf0b0a3a Parents: fc06b79 Author: Kenneth Knowles <[email protected]> Authored: Mon Jun 12 15:12:18 2017 -0700 Committer: Tyler Akidau <[email protected]> Committed: Wed Jul 12 20:01:02 2017 -0700 ---------------------------------------------------------------------- .../org/apache/beam/sdk/runners/TransformHierarchy.java | 10 +--------- 1 file changed, 1 insertion(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/83f31e94/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java index 6f1ee94..d8ff59e 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/runners/TransformHierarchy.java @@ -145,14 +145,6 @@ public class TransformHierarchy { Node producerNode = getProducer(inputValue); PInput input = producerInput.remove(inputValue); inputValue.finishSpecifying(input, producerNode.getTransform()); - checkState( - producers.get(inputValue) != null, - "Producer unknown for input %s", - inputValue); - checkState( - producers.get(inputValue) != null, - "Producer unknown for input %s", - inputValue); } } @@ -201,7 +193,7 @@ public class TransformHierarchy { } Node getProducer(PValue produced) { - return producers.get(produced); + return checkNotNull(producers.get(produced), "No producer found for %s", produced); } public Set<PValue> visit(PipelineVisitor visitor) {
