[
https://issues.apache.org/jira/browse/BEAM-2556?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16085603#comment-16085603
]
ASF GitHub Bot commented on BEAM-2556:
--------------------------------------
GitHub user cph6 opened a pull request:
https://github.com/apache/beam/pull/3558
[BEAM-2556] Implement retries in the read connector.
Retry failed RunQuery calls.
Respect non-retryable error codes from Datastore.
Add unit tests to check that retryable errors are retried.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cph6/beam datastore_better_error_handling
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3558.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3558
----
commit 016baf3465bbccbc9d3df6999b38b1b2533aee8c
Author: Colin Phipps <[email protected]>
Date: 2017-07-10T16:09:23Z
Implement retries in the read connector.
Respect non-retryable error codes from Datastore.
Add unit tests to check that retryable errors are retried.
----
> Client-side throttling for Datastore connector
> ----------------------------------------------
>
> Key: BEAM-2556
> URL: https://issues.apache.org/jira/browse/BEAM-2556
> Project: Beam
> Issue Type: Improvement
> Components: sdk-java-gcp
> Reporter: Colin Phipps
> Assignee: Colin Phipps
> Priority: Minor
> Labels: datastore
>
> The Datastore connector currently has exponential backoff on errors, which is
> good. But it does not do any other throttling of its write load in response
> to errors; once a request succeeds, it resumes writing as quickly as it can.
> Write loads will be more stable and more likely to compete if the client
> throttles itself in the event that it receives high rates of errors from the
> Datastore service; specifically
> https://landing.google.com/sre/book/chapters/handling-overload.html#client-side-throttling-a7sYUg
> is a technique that Google has had success with on other services.
> We (Datastore) have a patch in progress to add this behaviour to the
> connector.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
