Repository: beam Updated Branches: refs/heads/master 1f1df2722 -> 36c55ebc5
[BEAM-2608] Closes the reader in TextIO.readAll() Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/ce440a34 Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/ce440a34 Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/ce440a34 Branch: refs/heads/master Commit: ce440a34566ee9bd807f6e74a991f76849b3be49 Parents: 1f1df27 Author: Eugene Kirpichov <[email protected]> Authored: Sat Jul 15 10:43:13 2017 -0700 Committer: Eugene Kirpichov <[email protected]> Committed: Sat Jul 15 17:37:45 2017 -0700 ---------------------------------------------------------------------- .../core/src/main/java/org/apache/beam/sdk/io/TextIO.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/ce440a34/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java ---------------------------------------------------------------------- diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java index 78340f3..7b4c483 100644 --- a/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java +++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/io/TextIO.java @@ -462,12 +462,13 @@ public class TextIO { TextIO.Read.wrapWithCompression( new TextSource(StaticValueProvider.of(metadata.toString())), spec.getCompressionType()); - BoundedSource.BoundedReader<String> reader = + try (BoundedSource.BoundedReader<String> reader = source .createForSubrangeOfFile(metadata, range.getFrom(), range.getTo()) - .createReader(c.getPipelineOptions()); - for (boolean more = reader.start(); more; more = reader.advance()) { - c.output(reader.getCurrent()); + .createReader(c.getPipelineOptions())) { + for (boolean more = reader.start(); more; more = reader.advance()) { + c.output(reader.getCurrent()); + } } } }
