[
https://issues.apache.org/jira/browse/BEAM-2636?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16093477#comment-16093477
]
ASF GitHub Bot commented on BEAM-2636:
--------------------------------------
GitHub user sb2nov opened a pull request:
https://github.com/apache/beam/pull/3595
[BEAM-2636] Make sure we only override the correct class for WriteToBigQuery
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [ ] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [ ] Each commit in the pull request should have a meaningful subject
line and body.
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [ ] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [ ] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
R: @aaltay PTAL
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sb2nov/beam BEAM-2636-bq-override
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3595.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3595
----
commit 9056783c962cd1093eee3eca718bdbc5b42e554a
Author: Sourabh Bajaj <[email protected]>
Date: 2017-07-19T17:08:14Z
[BEAM-2636] Make sure we only override the correct class
----
> user_score on DataflowRunner is broken
> --------------------------------------
>
> Key: BEAM-2636
> URL: https://issues.apache.org/jira/browse/BEAM-2636
> Project: Beam
> Issue Type: Bug
> Components: sdk-py
> Affects Versions: 2.1.0
> Reporter: Ahmet Altay
> Assignee: Sourabh Bajaj
>
> UserScore has a custom transform named {{WriteToBigQuery}}, dataflow runner
> has a special code handling transforms with that name, this will break for
> all user transforms that has this name.
> We can either:
> - Handle this correctly
> - Or document this as a reserved keyword and change the example.
> cc: [~chamikara]
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
