Adjust pull request template for Jenkins and mergebot world Adds details about making a good series of commits, while removing advice that the user do things that Jenkins will do for them.
Project: http://git-wip-us.apache.org/repos/asf/beam/repo Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/4c6fa39f Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/4c6fa39f Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/4c6fa39f Branch: refs/heads/DSL_SQL Commit: 4c6fa39f619709ff127ca8418121ad91afa2041b Parents: 7e4719c Author: Kenneth Knowles <k...@google.com> Authored: Mon Jul 17 13:06:26 2017 -0700 Committer: Kenneth Knowles <k...@google.com> Committed: Mon Jul 17 15:59:39 2017 -0700 ---------------------------------------------------------------------- .github/PULL_REQUEST_TEMPLATE.md | 16 +++++++--------- 1 file changed, 7 insertions(+), 9 deletions(-) ---------------------------------------------------------------------- http://git-wip-us.apache.org/repos/asf/beam/blob/4c6fa39f/.github/PULL_REQUEST_TEMPLATE.md ---------------------------------------------------------------------- diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 868edd1..eeee750 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,12 +1,10 @@ -Be sure to do all of the following to help us incorporate your contribution -quickly and easily: +Follow this checklist to help us incorporate your contribution quickly and easily: - - [ ] Make sure the PR title is formatted like: - `[BEAM-<Jira issue #>] Description of pull request` - - [ ] Make sure tests pass via `mvn clean verify`. - - [ ] Replace `<Jira issue #>` in the title with the actual Jira issue - number, if there is one. - - [ ] If this contribution is large, please file an Apache - [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). + - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. + - [ ] Each commit in the pull request should have a meaningful subject line and body. + - [ ] Format the pull request title like `[BEAM-1234] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-1234` with the appropriate JIRA issue. + - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. + - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. + - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). ---
