[ 
https://issues.apache.org/jira/browse/BEAM-2499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096196#comment-16096196
 ] 

Etienne Chauchot commented on BEAM-2499:
----------------------------------------

I'm renaming this ticket and closing the above PR because supporting Custom 
Windows in Spark end up being a lot more than making {{SparkGlobalCombineFn}} 
generic. Indeed, it requires a complete re-coding of the window merging in a 
way similar to what is done in {{HashingFlinkCombineRunner}}.

> Support Custom Windows in Spark runner
> --------------------------------------
>
>                 Key: BEAM-2499
>                 URL: https://issues.apache.org/jira/browse/BEAM-2499
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-spark
>            Reporter: Etienne Chauchot
>            Assignee: Etienne Chauchot
>
> If we extend {{IntervalWindow}} and we try to merge these custom windows like 
> in this PR:
> https://github.com/apache/beam/pull/3286
> Then spark runner fails with 
> {{org.apache.beam.sdk.Pipeline$PipelineExecutionException: 
> java.lang.ClassCastException: 
> org.apache.beam.sdk.transforms.windowing.IntervalWindow cannot be cast to 
> org.apache.beam.sdk.transforms.windowing.MergingCustomWindowsTest$CustomWindow}}
> It seems to be because of the cast to {{IntervalWindow}} there: 
> https://github.com/apache/beam/blob/master/runners/spark/src/main/java/org/apache/beam/runners/spark/translation/SparkGlobalCombineFn.java#L111



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to