[
https://issues.apache.org/jira/browse/BEAM-2230?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16096209#comment-16096209
]
ASF GitHub Bot commented on BEAM-2230:
--------------------------------------
GitHub user evindj reopened a pull request:
https://github.com/apache/beam/pull/3533
[BEAM-2230] ApiSurface Refactoring
Be sure to do all of the following to help us incorporate your contribution
quickly and easily:
- [x] Make sure the PR title is formatted like:
`[BEAM-<Jira issue #>] Description of pull request`
- [x] Make sure tests pass via `mvn clean verify`.
- [x] Replace `<Jira issue #>` in the title with the actual Jira issue
number, if there is one.
- [x] If this contribution is large, please file an Apache
[Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
---
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/evindj/beam BEAM-2230
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3533.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3533
----
commit a0a90f298a5c3131a887193cccb278fbf45e61b5
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-10T04:30:46Z
Made ApiSurface abstract and created implementing subclasses
commit c800fb95b7f9a622f4a9dc2fa061764610739298
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-10T05:34:18Z
Created the direct runner api surface sub class
commit a532663cf2650d0f5dfbc6ea7838e3c5da77a1bb
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-10T05:52:22Z
Modified GcpApiSurface to reflect the correct Api Surface
commit d696b2323bcf89d9272bed94c860dac091bffe3d
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-10T06:02:03Z
Fixed Core Google Cloud API surface.
commit 4a321dc4e07087d0fc4148268f83552fa5b65be6
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-10T11:25:08Z
Fixed a bug in GcpApiSurface
commit 25c6a62bd887066a3c5532a0843355814385b94a
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-10T12:09:52Z
Added ASF Licence in DirectRunnerApiSurface
commit 5977469f6304d7cf2595297ec941f3671ab2b2a7
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-21T04:31:06Z
Merge branch 'master' of https://github.com/apache/beam into BEAM-2230
commit e70a64da7e6899d8db1630d99a361e77f552fa9b
Author: Innocent Djiofack <[email protected]>
Date: 2017-07-21T05:29:36Z
Modified code by review comments.
----
> Core SDK ApiSurface should be only org.apache.beam.sdk and should be defined
> outside of the general ApiSurface class
> --------------------------------------------------------------------------------------------------------------------
>
> Key: BEAM-2230
> URL: https://issues.apache.org/jira/browse/BEAM-2230
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Kenneth Knowles
> Assignee: Innocent
>
> Currenlty, ApiSurface.getSdkApiSurface() is highly specialized and also not
> correct.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
