[
https://issues.apache.org/jira/browse/BEAM-2642?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16097805#comment-16097805
]
ASF GitHub Bot commented on BEAM-2642:
--------------------------------------
GitHub user lukecwik opened a pull request:
https://github.com/apache/beam/pull/3622
[BEAM-2642] Update Google Auth to 0.7.1
Google auth libraries 0.6.1 and 0.7.1 have the same versions of
dependencies.
Follow this checklist to help us incorporate your contribution quickly and
easily:
- [x] Make sure there is a [JIRA
issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the
change (usually before you start working on it). Trivial changes like typos do
not require a JIRA issue. Your pull request should address just this issue,
without pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject
line and body.
- [x] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue.
- [x] Write a pull request description that is detailed enough to
understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more
thorough check will be performed on your pull request automatically.
- [x] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
---
This is a really annoying bug for Dataflow customers, if a 2.1.0 RC3 gets
built. I would like to include this PR into it.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/lukecwik/incubator-beam beam2642release
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3622.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3622
----
commit a98031c28c352cfc8c16f53fc7a58a7aed390b64
Author: Luke Cwik <[email protected]>
Date: 2017-07-19T18:36:35Z
[BEAM-2642] Update Google Auth to 0.7.1
Google auth libraries 0.6.1 and 0.7.1 have the same versions of
dependencies.
----
> Upgrade to Google Auth 0.7.1
> ----------------------------
>
> Key: BEAM-2642
> URL: https://issues.apache.org/jira/browse/BEAM-2642
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-gcp
> Affects Versions: 2.0.0, 2.1.0
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Fix For: 2.2.0
>
>
> Looking up application default credentials on a GCE VM can fail due to VM
> metadata server being unavailable during VM launch. This is a rare event but
> Google Cloud Dataflow customers hit this rare case one or two times a month
> due to the sheer number of VMs. GCE attempted to mitigate VM metadata server
> unavailability but were only able to reduce it be an order of magnitude thus
> we need support from the client to retry. Additionally, when contacting the
> GCE VM metadata server, we should be using the fixed IP address avoiding the
> nameserver lookup (another potential point of failure).
> Problem area in the code:
> https://github.com/google/google-auth-library-java/blob/b94f8e4d02bf6917af2e2f7ef8d7114a51dbcfa8/oauth2_http/java/com/google/auth/oauth2/DefaultCredentialsProvider.java#L261
> Note that the code in this library and the Apiary auth support code are very
> similar. The fix was done within the Apiary auth code (note the use of the
> static IP address and also the presence of a fixed number of retries):
> https://github.com/google/google-api-java-client/blob/4fc8c099d9db5646770868cc1bc9a33c9225b3c7/google-api-client/src/main/java/com/google/api/client/googleapis/auth/oauth2/OAuth2Utils.java#L74
> It turned out that the fixes resulted in zero future customer contacts about
> this issue.
> Google Auth 0.7.1 was released containing these fixes mentioned in
> https://github.com/google/google-auth-library-java/issues/109
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
