[ 
https://issues.apache.org/jira/browse/BEAM-2441?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16107010#comment-16107010
 ] 

ASF GitHub Bot commented on BEAM-2441:
--------------------------------------

GitHub user xumingming opened a pull request:

    https://github.com/apache/beam/pull/3666

    [BEAM-2441] move dsls/sql to sdks/java/extensions/sql

    R: @XuMingmin @takidau 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2441

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/3666.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3666
    
----
commit ba493f85a5a18665cd6ae4eb61e0a86fab1a6c07
Author: James Xu <xumingmi...@gmail.com>
Date:   2017-07-30T15:39:37Z

    move dsls/sql to sdks/java/extensions/sql

commit c1b5482d3fb13a14926f0ffc23d0810b3105ed24
Author: James Xu <xumingmi...@gmail.com>
Date:   2017-07-30T15:58:02Z

    rename package org.apache.beam.dsls.sql to 
org.apache.beam.sdk.extensions.sql

commit febd044ae306a28fa3797a1663e54c1d7fbe43ce
Author: James Xu <xumingmi...@gmail.com>
Date:   2017-07-31T09:11:53Z

    move all implementation classes/packages into impl package

----


> DSL SQL maven module location and name
> --------------------------------------
>
>                 Key: BEAM-2441
>                 URL: https://issues.apache.org/jira/browse/BEAM-2441
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Luke Cwik
>            Assignee: James Xu
>              Labels: dsl_sql_merge
>
> The current maven module location is *dsl/sql*, unfortunately this occludes 
> the fact that this is for the Java SDK and also prevents alternative language 
> implementations.
> Some alternative locations could be:
> {code}
> sdks/java/extensions/sql
> sdks/java/dsls/sql
> dsls/sql/java
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to