[
https://issues.apache.org/jira/browse/BEAM-2676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16110516#comment-16110516
]
ASF GitHub Bot commented on BEAM-2676:
--------------------------------------
GitHub user XuMingmin opened a pull request:
https://github.com/apache/beam/pull/3675
[BEAM-2676] move BeamSqlRow and BeamSqlRowType to sdk/java/core
create a new PR to get rid of the huge rebase work after #3666.
Following the discussion in
[BEAM-2676](https://issues.apache.org/jira/browse/BEAM-2676), the changes are
outlined as:
1. `BeamRecord` and `BeamRecordTypeProvider` are marked as `@Experimental`;
2. `BeamRecord` is moved to sdk/core, which includes a default
`BeamRecordTypeProvider` to define type information; Also a `BeamRecordCoder`
is provided as Coder;
3. In _extension/sql_, `BeamSqlRecord` extends `BeamRecord`,
`BeamSqlRecordTypeProvider` extends `BeamRecordTypeProvider` to support SQL
types; a new Coder `BeamSqlRecordCoder` is provided to align better;
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XuMingmin/beam BEAM-2676_2
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/beam/pull/3675.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3675
----
commit 09a7148e603f8d8521f916008f92b0e95ae7c14f
Author: mingmxu <[email protected]>
Date: 2017-08-02T08:20:50Z
move BeamRecord to sdk/core
----
> move BeamSqlRow and BeamSqlRowType to sdk/java/core
> ---------------------------------------------------
>
> Key: BEAM-2676
> URL: https://issues.apache.org/jira/browse/BEAM-2676
> Project: Beam
> Issue Type: Test
> Components: dsl-sql
> Reporter: Xu Mingmin
> Assignee: Xu Mingmin
> Labels: dsl_sql_merge
>
> BeamSqlRow/BeamSqlRowType is the fundamental of structured data processing in
> Beam, like joins, simple projections/expansions. It's more visible to move
> them to sdk-java-core.
> It contains two parts:
> 1). remove SQL word in the name,
> BeamSqlRow --> BeamRow
> BeamSqlRowType --> BeamRowType
> 2). move from package {{org.apache.beam.dsls.sql.schema}} to
> {{org.apache.beam.sdk.sd}} (sd stands for structure data), in module
> {{beam-sdks-java-core}}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
