[
https://issues.apache.org/jira/browse/BEAM-2735?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16116566#comment-16116566
]
Etienne Chauchot commented on BEAM-2735:
----------------------------------------
I only re-coded the input collection creation by using {{TestStream}} in the
two testMergingCustomWindows* tests like you suggested. Please see
https://github.com/echauchot/beam/blob/BEAM-2735-fix-custom-window-test-in-streaming/sdks/java/core/src/test/java/org/apache/beam/sdk/transforms/windowing/WindowTest.java
But the tests pass using direct runner.
Did I miss something?
> testMergingCustomWindows tests are incorrect
> --------------------------------------------
>
> Key: BEAM-2735
> URL: https://issues.apache.org/jira/browse/BEAM-2735
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Affects Versions: 2.2.0
> Reporter: Thomas Groh
> Assignee: Etienne Chauchot
>
> If the input is rewritten to use to use {{TestStream}}, and executes in the
> DirectRunner, the tests fail. My expectation is that this is due to a
> disagreement in what the tests expect to be merged (if all of the merging
> logic is run only once), as opposed to running the merging logic
> incrementally with a perfect watermark.
> This is also causing failures in the Dataflow {{ValidatesRunner}} suite.
> {code:java}
> PCollection<String> inputCollection =
> pipeline.apply(
> TestStream.create(StringUtf8Coder.of())
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(10L)))
> .addElements("big")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(20L)))
> .addElements("small1")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(39L)))
> .addElements("small2")
>
> .advanceWatermarkTo(startInstant.plus(Duration.standardSeconds(250L)))
> .advanceWatermarkToInfinity());
> {code}
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
