ASF GitHub Bot commented on BEAM-2733:

GitHub user xumingming opened a pull request:


    [BEAM-2733] update javadoc for BeamSql

    * `Exception` declaration are removed from `BeamSql.query ()`
    * Added javadoc to explain when the sql query use a non-exist table态a 
subset of tables from upstream, what happens.
    * Added javadoc for BeamSql.query and QueryTransform to describe the 
lifetime of tables in PCollectionTuple.
    * SimpleQueryTransform and QueryTransform are actually user-facing (they 
are return types of query() and simpleQuery()), so they are kept `public`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/xumingming/beam BEAM-2733-BeamSql

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3704
commit df4d24f2104b61b65bbfc027d005415d4282c992
Author: James Xu <xumingmi...@gmail.com>
Date:   2017-08-08T11:52:53Z

    [BEAM-2733] update javadoc for BeamSql


> update JavaDoc of BeamSql
> -------------------------
>                 Key: BEAM-2733
>                 URL: https://issues.apache.org/jira/browse/BEAM-2733
>             Project: Beam
>          Issue Type: Sub-task
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: James Xu
>              Labels: dsl_sql_merge, dsl_sql_review
> refer to discussions:
> 1. 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmFcik
> 2. 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhfc
> 3. 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhfU
> 4. 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhfY
> 5. 
> https://docs.google.com/document/d/1VlAqKLhQua6YpR42KuziIYHTB1FfQTi16Mh88MEYBsU/edit?disco=AAAABTmjhfQ

This message was sent by Atlassian JIRA

Reply via email to